Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage of third body species #614

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

K20shores
Copy link
Collaborator

@K20shores K20shores commented Aug 7, 2024

Fix #613. The full writeup is in the issue, but ensuring that the species object in the list of products and reactants contains information on whether something is a third body by copying the value from the species array during a read of a configuration file allows the process set to properly detect if a species is a third body or not and fixes our usage of third body species

@K20shores K20shores linked an issue Aug 7, 2024 that may be closed by this pull request
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One question here,
Can "tracer_type": "CONSTANT" be always converted to "tracer type": "THIRD_BODY"?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (c74099c) to head (4155437).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   93.48%   93.51%   +0.03%     
==========================================
  Files          49       49              
  Lines        3500     3502       +2     
==========================================
+ Hits         3272     3275       +3     
+ Misses        228      227       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@K20shores
Copy link
Collaborator Author

Looks good! One question here, Can "tracer_type": "CONSTANT" be always converted to "tracer type": "THIRD_BODY"?

I don't know. I don't think we really respect CONSTANT right now

@K20shores K20shores merged commit 4a2908a into main Aug 7, 2024
29 checks passed
@K20shores K20shores deleted the 613-third-body-species-are-not-properly-used branch August 7, 2024 16:12
@carl-drews
Copy link

        "tracer type": "THIRD_BODY",

causes musica.micm_solve() to crash.
"tracer type": "CONSTANT",
does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Third body species are not properly used
5 participants