Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the local copy of Jacobian matrix when doing LU decomposition #646

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

sjsprecious
Copy link
Collaborator

This PR:

  • removes the generation of local copy of Jacobian matrix
  • reconstructs the Jacobian matrix when a substepping is needed for the LU decomposition

fix #644

@sjsprecious sjsprecious self-assigned this Sep 4, 2024
@sjsprecious sjsprecious added the enhancement New feature or request label Sep 4, 2024
@sjsprecious sjsprecious added this to the CUDA Rosenbrock Solver milestone Sep 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (7c5f4bf) to head (821beb5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #646   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files          49       49           
  Lines        3500     3502    +2     
=======================================
+ Hits         3273     3275    +2     
  Misses        227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjsprecious sjsprecious merged commit 51f6942 into main Sep 4, 2024
29 checks passed
@sjsprecious sjsprecious deleted the 644_remove_local_copy_jacobian branch September 4, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid the local copy of Jacobian matrix when doing LuDecompose
4 participants