Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistep training with batch_size >=1 per GPU #139

Merged
merged 19 commits into from
Jan 1, 2025
Merged

Conversation

jsschreck
Copy link
Collaborator

No description provided.

@kanz76 kanz76 self-requested a review December 24, 2024 03:50
@jsschreck jsschreck requested a review from dkimpara December 25, 2024 15:37
@dkimpara
Copy link
Collaborator

can you add some details? is this going to replace all trainers/datasets or just the multistep ones?

@jsschreck
Copy link
Collaborator Author

can you add some details? is this going to replace all trainers/datasets or just the multistep ones?

I just added the single-step dataset. I am aiming for consolidation down to a single trainer with config options to specify what you need to do (single or multi). Working on that and should have it ready by end of week. So far the train_multistep.py in this PR has been tested with the new multi-step datasets. I will update documentation and what not once its all working.

@jsschreck
Copy link
Collaborator Author

@kanz76 I think the bug involving batch size and history len is now corrected.

@jsschreck jsschreck requested a review from djgagne December 28, 2024 17:12
@kanz76 kanz76 self-requested a review December 29, 2024 19:00
Copy link
Collaborator

@kanz76 kanz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested

  • era5_multistep_batcher.py (exceptMultiprocessingBatcherPrefetch)
  • load_dataset_and_dataloader.py
  • train_universal.py

They all look good!

@kanz76 kanz76 self-requested a review December 31, 2024 21:59
@jsschreck jsschreck merged commit 082fe64 into main Jan 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants