Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in computation of outputs SNOWENERGY and SOILENERGY for glacierized grid cells #140

Open
emilycollier opened this issue Sep 3, 2024 · 3 comments · May be fixed by #141
Open

Bug in computation of outputs SNOWENERGY and SOILENERGY for glacierized grid cells #140

emilycollier opened this issue Sep 3, 2024 · 3 comments · May be fixed by #141

Comments

@emilycollier
Copy link

emilycollier commented Sep 3, 2024 •
edited
Loading

In WRF v4.6.0, the heat capacity variable HCPCT is not initialized in module_sf_noahmpdrv.F, nor is it passed to/return from the call to noahmp_glacier in module_sf_noahmp_glacier.F. As a result, the computations for the output variables SNOWENERGY and SOILENERGY at L1380-1394 are not correct for glacierized grid cells, and simulations are not reproducible.

If you would like a PR, can you please let me know for which branch exactly? Thanks.
@tslin2
Copy link
Collaborator

tslin2 commented Sep 3, 2024 •
edited
Loading

You may refer https://github.com/NCAR/hrldas/blob/master/tutorial/Note4_Code_Development_GitHub_Pull_Request.ipynb to the develop or NCAR:release-v4.6-WRF branch.
Thanks.

emilycollier added a commit to emilycollier/noahmp that referenced this issue Sep 6, 2024
@emilycollier
bug fix for HCPCT variable for glacierized grid cells (issue NCAR#140)
9e7012e
@jesusff
Copy link

jesusff commented Sep 13, 2024

Thank you, Emily. Does this bug affect the default opt_gla = 1 configuration for glacier treatment?

jesusff pushed a commit to CORDEX-WRF-community/noahmp that referenced this issue Sep 13, 2024
@emilycollier @jesusff
bug fix for HCPCT variable for glacierized grid cells (issue NCAR#140)
90d6194
@emilycollier
Copy link
Author

As it relates to an incorrect initialization and update of HCPCT in the driving module, I think it is independent of any of the optional treatments, however it only impacts the diagnostics SNOWENERGY and SOILENERGY in glacierized grid cells.

@tslin2 tslin2 linked a pull request Oct 9, 2024 that will close this issue
bug fix for HCPCT variable for glacierized grid cells (issue #140) #141
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug fix for HCPCT variable for glacierized grid cells (issue #140) emilycollier/noahmp
3 participants
@jesusff @emilycollier @tslin2