Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for HCPCT variable for glacierized grid cells (issue #140) #141

Closed

Conversation

emilycollier
Copy link

No description provided.

Copy link
Collaborator

@tslin2 tslin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me. Thanks.

@cenlinhe
Copy link
Collaborator

I have combined this bug fix with other recent ones in the release-WRF-v4.7 branch, so I am going to close this PR here. Thank you for your contribution!

@cenlinhe cenlinhe closed this Jan 25, 2025
weiwangncar pushed a commit to wrf-model/WRF that referenced this pull request Jan 29, 2025
TYPE: bug fix

KEYWORDS: snow albedo, soil timestep, glacier heat capacity

SOURCE: Cenlin He (NCAR)

DESCRIPTION OF CHANGES:
Bug fixes for the following three parts:
1. allow BATS snow albedo scheme for nighttime snow aging: NCAR/ccpp-physics#1091
2. fix the potential leakage caused by calculate_soil variable during parallelization: NCAR/noahmp#136
3. fix the missing of HCPCT output for glacier points: NCAR/noahmp#141

LIST OF MODIFIED FILES: only Noah-MP source code is changed in Noah-MP GitHub.
phys/noahmp

TESTS:
The changes have passed the regression tests.

RELEASE NOTE: Noah-MP bug fixes for (1) allowing BATS snow albedo scheme for nighttime snow aging, (2) the potential leakage caused by calculate_soil variable during parallelized run, (3) the missing of HCPCT output for glacier points.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in computation of outputs SNOWENERGY and SOILENERGY for glacierized grid cells
3 participants