Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/transition-to-capgen-1: update SDF syntax and XML schema, remove DDT dependency in radiation physics, correct units #65

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 6, 2020

Description

This PR only updates the submodule pointers for fv3atm, ccpp-framework and ccpp-physics for the changes described in the associated PRs:

  • support for removal of GFS DDTs from CCPP radiation physics from @grantfirl
  • correct metadata name/unit/dimensions from @mzhangw
  • update XML schema and syntax for all suite definition files; all SDFs validate against suite.xsd using xmllint

Testing

Regression tests against existing baselines passed on the following platforms:

  • cheyenne.gnu
  • cheyenne.intel

This is sufficient for the purpose of updating feature/transition-to-capgen-1. Full regression tests on all tier-1 platforms will be run when feature/transition-to-capgen-1 is sent to the authoritative repositories.

Output from xmllint, showing that all suites validate against the updated/simplified suites.xsd schema:

xmllint_output_20201005T1700.txt

Dependencies

NCAR/ccpp-physics#506
NCAR/ccpp-framework#327
NCAR/fv3atm#64
#65

@climbfuji climbfuji marked this pull request as ready for review October 7, 2020 13:26
Copy link
Collaborator

@mzhangw mzhangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@climbfuji climbfuji merged commit 050609f into NCAR:feature/transition-to-capgen-1 Oct 7, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Mar 25, 2021
)

* Update submodule pointer for fv3atm
* Copy new Thompson tables from temporary location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants