-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physics cleanup #67
Physics cleanup #67
Conversation
…r-model into accumulated_cleanup
… accumulated_cleanup
on-behalf-of @ufs-community <dswales@ucar.edu>
Automated RT Failure Notification |
Automated RT Failure Notification |
Automated RT Failure Notification |
Automated RT Failure Notification |
Automated RT Failure Notification |
@grantfirl FYI. Something isn't working as expected with the auto-RTs that I need to suss out. I will plan to work on this early next week. |
@grantfirl All tests are complete. I forgot that we skipped the RTs on Cheyenne last time around, so I needed to go in there and copy the new ones over. Only changes to GP baselines. |
@dustinswales OK, would you like to go ahead and merge this in then and start PRs in UFS/dev? Since there are changes in NoahMP, there might be a need to bring changes over to their repo, but I don't know if that is our responsibility or not. I guess we'll find out once the PRs into UFS/dev are there. We can also talk to Chunxi about it this afternoon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the dprefix change in rt.ncar.sh before merging.
@grantfirl Done. Can you please re-approve? |
* Update FV3 * Merge pull request NCAR#67 from dustinswales/accumulated_cleanup * Updated physics * Reverting DISKNM/gaea to original * add new BL_DATE
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions:
This PR contains changes to the underlying FV3 and ccpp-physics submodules and updates to a few regression tests.
Issue(s) addressed
Detailed in NCAR #956
Testing
Tested on Cheyenne and Hera with Intel.
Updates need for the RRTMGP RTs (see conversation in NCAR/ccpp-physics#956)