Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UFS-dev PR#18 #80

Merged
merged 13 commits into from
Dec 26, 2022
Merged

UFS-dev PR#18 #80

merged 13 commits into from
Dec 26, 2022

Conversation

grantfirl
Copy link
Collaborator

Identical to ufs-community#1480

lisa-bengtsson and others added 3 commits December 5, 2022 10:24
@lisa-bengtsson @JessicaMeixner-NOAA
@jkbk2004 @BrianCurtis-NOAA
Update Regression Test to include gfsv17 prototypes that are after pr…
659bd98 
…ototype 8, and turn on prognostic closure. (ufs-community#1480)

* Generation of gfsv17 tests for RT's beyond P8, updates in FV3 and ccpp submodules

* Added DNATS=0 flag to not exclude any tracers from advection

* update TKE contribution from cu for progsigma in deep and shallow cu

* Correct noareo tests to set DNATS=0 to ensure advection of all tracers

* Address review comments - clean out P7 and P8 labels in GFSv17 tests

* update rt.conf removing old control tests, adding a cpld gfsv17 test

* add outerloop wave coupling to a gfsv17 test

* remove duplicate test

Co-authored-by: Jessica Meixner <Jessica.Meixner@noaa.gov>
Co-authored-by: jkbk2004 <jong.kim@noaa.gov>
Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
update FV3 submodule and .gitmodules for testing
70cf43c
Merge commit '659bd98' into ufs-dev-PR18
d01c015
@grantfirl
Copy link
Collaborator Author

Contains changes from #79 until that is merged

@grantfirl grantfirl mentioned this pull request Dec 20, 2022
Merged
@grantfirl
Copy link
Collaborator Author

Requires new baselines due to new RT: see ufs-community#1480

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: BL
[BL] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1172581620/20221220213010/ufs-weather-model
[BL] ERROR: Baseline location exists before creation:
/scratch1/BMC/gmtb/RT/NCAR/main-20221219/INTEL
Please make changes and add the following label back: hera-intel-BL

dustinswales added 2 commits December 20, 2022 14:50
[AutoRT] cheyenne.gnu Job Completed.
6b00dc6 
on-behalf-of @NCAR <dswales@ucar.edu>
[AutoRT] hera.gnu Job Completed.
452a773 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/auto_RT/Pull_Requests/1172581620/20221220143010/ufs-weather-model
[RT] Error: Test cpld_control_gfsv17 001 failed in check_result failed
[RT] Error: Test cpld_control_gfsv17 001 failed in run_test failed
[RT] Error: Test cpld_control_noaero_p8 011 failed in check_result failed
[RT] Error: Test cpld_control_noaero_p8 011 failed in run_test failed
[RT] Error: Test cpld_debug_noaero_p8 014 failed in check_result failed
[RT] Error: Test cpld_debug_noaero_p8 014 failed in run_test failed
Please make changes and add the following label back: cheyenne-intel-RT

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1172581620/20221220211513/ufs-weather-model
[RT] Error: Test cpld_control_gfsv17 001 failed in check_result failed
[RT] Error: Test cpld_control_gfsv17 001 failed in run_test failed
[RT] Error: Test cpld_control_noaero_p8 013 failed in check_result failed
[RT] Error: Test cpld_control_noaero_p8 013 failed in run_test failed
[RT] Error: Test cpld_debug_noaero_p8 016 failed in check_result failed
[RT] Error: Test cpld_debug_noaero_p8 016 failed in run_test failed
Please make changes and add the following label back: hera-intel-RT

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: gnu
Job: BL
[BL] Repo location: /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/auto_RT/Pull_Requests/1172581620/20221220163010/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location: /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/auto_RT/Pull_Requests/1172581620/20221220165942/ufs-weather-model
[RT] Error: Test rap_decomp 006 failed in run_test failed
[RT] Error: Test rap_restart 008 failed in run_test failed
[RT] Error: Test rap_sfcdiff 009 failed in run_test failed
[RT] Error: Test rap_sfcdiff_decomp 010 failed in run_test failed
[RT] Error: Test hrrr_control_2threads 013 failed in run_test failed
[RT] Error: Test hrrr_control_decomp 014 failed in run_test failed
[RT] Error: Test hrrr_control_restart 015 failed in run_test failed
[RT] Error: Test rrfs_v1beta 016 failed in run_test failed
[RT] Error: Test regional_debug 022 failed in run_test failed
[RT] Error: Test rap_diag_debug 025 failed in run_test failed
[RT] Error: Test control_debug_p8 031 failed in run_test failed
[RT] Error: Test rrfs_conus13km_radar_tten_warm_debug 033 failed in run_test failed
[RT] Error: Test rap_control_dyn32_phy32 035 failed in run_test failed
[RT] Error: Test rap_2threads_dyn32_phy32 037 failed in run_test failed
[RT] Error: Test rap_control_dyn64_phy32_debug 045 failed in run_test failed
[RT] Error: Test cpld_control_p8 046 failed in run_test failed
[RT] Error: Test compile_006 failed in run_compile failed
Please make changes and add the following label back: cheyenne-gnu-BL

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: BL
[BL] Repo location: /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/auto_RT/Pull_Requests/1172581620/20221220164507/ufs-weather-model
[BL] Error: Test cpld_control_c192_p8 004 failed in run_test failed
[BL] Error: Test rrfs_conus13km_hrrr_warm_debug 047 failed in run_test failed
[BL] Error: Test rrfs_conus13km_radar_tten_warm_debug 048 failed in run_test failed
[BL] Error: Test control_CubedSphereGrid_debug 049 failed in run_test failed
[BL] Error: Test control_wrtGauss_netcdf_parallel_debug 050 failed in run_test failed
[BL] Error: Test control_csawmg_debug 053 failed in run_test failed
[BL] Error: Test control_csawmgt_debug 054 failed in run_test failed
[BL] Error: Test control_ras_debug 055 failed in run_test failed
[BL] Error: Test control_diag_debug 056 failed in run_test failed
[BL] Error: Test control_debug_p8 057 failed in run_test failed
[BL] Error: Test regional_debug 058 failed in run_test failed
[BL] Error: Test rap_control_debug 059 failed in run_test failed
[BL] Error: Test hrrr_control_debug 060 failed in run_test failed
[BL] Error: Test rap_diag_debug 061 failed in run_test failed
[BL] Error: Test rap_cires_ugwp_debug 062 failed in run_test failed
[BL] Error: Test rap_lndp_debug 063 failed in run_test failed
[BL] Error: Test rap_flake_debug 064 failed in run_test failed
[BL] Error: Test rap_progcld_thompson_debug 065 failed in run_test failed
[BL] Error: Test rap_noah_debug 066 failed in run_test failed
[BL] Error: Test rap_rrtmgp_debug 067 failed in run_test failed
[BL] Error: Test rap_sfcdiff_debug 068 failed in run_test failed
[BL] Error: Test rap_noah_sfcdiff_cires_ugwp_debug 069 failed in run_test failed
[BL] Error: Test rrfs_v1beta_debug 070 failed in run_test failed
[BL] Error: Test hafs_regional_atm 079 failed in run_test failed
[BL] Error: Test hafs_regional_atm_thompson_gfdlsf 080 failed in run_test failed
[BL] Error: Test hafs_regional_atm_ocn 081 failed in run_test failed
[BL] Error: Test hafs_regional_atm_wav 082 failed in run_test failed
[BL] Error: Test hafs_regional_atm_ocn_wav 083 failed in run_test failed
[BL] Error: Test hafs_regional_1nest_atm 084 failed in run_test failed
[BL] Error: Test hafs_regional_telescopic_2nests_atm 085 failed in run_test failed
[BL] Error: Test hafs_global_1nest_atm 086 failed in run_test failed
[BL] Error: Test hafs_global_multiple_4nests_atm 087 failed in run_test failed
[BL] Error: Test hafs_regional_specified_moving_1nest_atm 088 failed in run_test failed
[BL] Error: Test hafs_regional_storm_following_1nest_atm_ocn 090 failed in run_test failed
[BL] Error: Test hafs_regional_storm_following_1nest_atm_ocn_wav 091 failed in run_test failed
[BL] Error: Test hafs_global_storm_following_1nest_atm 092 failed in run_test failed
[BL] Error: Test hafs_regional_docn 093 failed in run_test failed
[BL] Error: Test hafs_regional_docn_oisst 094 failed in run_test failed
[BL] Error: Test hafs_regional_datm_cdeps 095 failed in run_test failed
[BL] Error: Test datm_cdeps_mx025_cfsr 103 failed in run_test failed
[BL] Error: Test datm_cdeps_mx025_gefs 104 failed in run_test failed
[BL] Error: Test regional_atmaq_debug 115 failed in run_test failed
[BL] Error: Test compile_022 failed in run_compile failed
[BL] Error: Test compile_023 failed in run_compile failed
[BL] Error: Test compile_024 failed in run_compile failed
[BL] Error: Test compile_025 failed in run_compile failed
Please make changes and add the following label back: cheyenne-intel-BL

[AutoRT] hera.gnu Job Completed.
c475852 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: BL
[BL] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1172581620/20221220233011/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1172581620/20221221012742/ufs-weather-model
Please make changes and add the following label back: hera-gnu-BL

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: BL
[BL] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1172581620/20221220234509/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1172581620/20221221013850/ufs-weather-model
[RT] Error: Test control_2dwrtdecomp 021 failed in check_result failed
[RT] Error: Test control_2dwrtdecomp 021 failed in run_test failed
[RT] Error: Test control_fhzero 022 failed in check_result failed
[RT] Error: Test control_fhzero 022 failed in run_test failed
[RT] Error: Test control_2threads_debug 078 failed in check_result failed
[RT] Error: Test control_2threads_debug 078 failed in run_test failed
Please make changes and add the following label back: hera-intel-BL

@grantfirl
Copy link
Collaborator Author

@dustinswales We are out of space on Cheyenne again. Could you remove the rt_* data in /glade/scratch/dswales/FV3_RT and delete the created baselines in /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/NCAR/main-20221220/* please? Should we also consider deleting some of the old baseline data if it is counting against the same quota?

@dustinswales
Copy link
Collaborator

@grantfirl Yes I will clean up some space on Cheyenne now.
Removing some old baselines will definitely help. How many should we keep? (I think 3 would suffice, just off the top of my head)

@grantfirl
Copy link
Collaborator Author

@grantfirl Yes I will clean up some space on Cheyenne now. Removing some old baselines will definitely help. How many should we keep? (I think 3 would suffice, just off the top of my head)

Sure, 3 sounds fine. I'm going to need to apply the changes in ufs-community@7e98ecf (which is ahead of the current PR) in order for the hera/intel RTs to pass.

@grantfirl
Copy link
Collaborator Author

@dustinswales Could you also remove /scratch1/BMC/gmtb/RT/NCAR/main-20221220/INTEL so that we can rerun hera-intel-BL please?

@dustinswales
Copy link
Collaborator

@grantfirl Yes I will clean up some space on Cheyenne now. Removing some old baselines will definitely help. How many should we keep? (I think 3 would suffice, just off the top of my head)

Sure, 3 sounds fine. I'm going to need to apply the changes in ufs-community@7e98ecf (which is ahead of the current PR) in order for the hera/intel RTs to pass.

I cleared up a bunch of space, apply tags at will!

/scratch1/BMC/gmtb/RT/NCAR/main-20221220/INTEL

done

[AutoRT] cheyenne.gnu Job Completed.
70cfda6 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: gnu
Job: BL
[BL] Repo location: /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/auto_RT/Pull_Requests/1172581620/20221221160008/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location: /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/auto_RT/Pull_Requests/1172581620/20221221182456/ufs-weather-model
Please make changes and add the following label back: cheyenne-gnu-BL

[AutoRT] hera.intel Job Completed.
308ae11 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: BL
[BL] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1172581620/20221221230017/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1172581620/20221222010058/ufs-weather-model
Please make changes and add the following label back: hera-intel-BL

[AutoRT] cheyenne.intel Job Completed.
1208f26 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: BL
[BL] Repo location: /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/auto_RT/Pull_Requests/1172581620/20221221161507/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location: /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/auto_RT/Pull_Requests/1172581620/20221221190148/ufs-weather-model
Please make changes and add the following label back: cheyenne-intel-BL

@grantfirl
Copy link
Collaborator Author

I think that this is ready to merge once this and NCAR/fv3atm#78 are approved.

@grantfirl grantfirl merged commit 3992d58 into NCAR:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinswales dustinswales dustinswales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grantfirl @dustinswales @lisa-bengtsson