Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation commands #120

Merged
merged 4 commits into from
Sep 26, 2020
Merged

Conversation

davidhassell
Copy link
Collaborator

Move creation_commands methods from cf-python to cfdm, as mentioned in NCAS-CMS/cfdm#53

Companion PR to NCAS-CMS/cfdm#82

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Sep 25, 2020

Re-triggering the CI tests here (via open-close) now that NCAS-CMS/cfdm#82 has been merged such that the creation commands have become available to cf-python from that, where they were removed in this PR, such the tests should pass unless further work needs to be done to get the right end-to-end behaviour.

I've observed an e2e pass locally so expect a pass unless there are issues on Mac OS platforms.

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Sep 25, 2020

Interestingly there are a couple of CI failures (plus one test failure probably unrelated since we've seen it before, which I will look into), both on test_docstring. Locally they also fail when I run them separately (python test_docstring.py), but they pass if run as part of python run_tests.

(Next week at normal working hours) it would be good to see if you see the same locally, David. It is certainly possible I am doing something silly, but I may not be...

Otherwise I will leave this to you. The test failures look simple to resolve. Thanks.

@sadielbartholomew
Copy link
Member

Oh, it looks like you have already solved the pair of test failures in NCAS-CMS/cfdm#83. 👍

@davidhassell
Copy link
Collaborator Author

Ah yes - sorry I forgot to mention that one. I think we can merge, now.

@davidhassell davidhassell merged commit 356d80b into NCAS-CMS:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants