dask: Dask.digitize
#312
Merged
dask: Dask.digitize
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
A few minor comments raised in-line, but otherwise everything looks good. As for the CI jobs, I'm not sure why the 'Run test suite' jobs ran since this is a PR to lama-to-dask, regardless they aren't relevant yet so we can ignore the failures there. The relevant tests ('Test cf.Data' and 'Linting') do pass so that indicates everything is good test-wise, along with a local pass I have observed of course.
Feel free to merge once you have seen and responded as you wish to the in-line comments! Thanks.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.