Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data.empty, Data.full, Data.ones, Data.zeros #315

Merged
merged 6 commits into from
Feb 9, 2022
Merged

dask: Data.empty, Data.full, Data.ones, Data.zeros #315

merged 6 commits into from
Feb 9, 2022

Conversation

davidhassell
Copy link
Collaborator

No description provided.

@davidhassell davidhassell added the dask Relating to the use of Dask label Feb 7, 2022
@davidhassell davidhassell mentioned this pull request Feb 7, 2022
Closed
sadielbartholomew
sadielbartholomew approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments you may wish to address, but this looks great (and we can ignore the failing 'Run test suite' and similar CI jobs which shouldn't have run for this PR, I will check why they triggered). Thanks. Merge at will!

cf/data/data.py Outdated Show resolved Hide resolved
cf/docstring/docstring.py Outdated Show resolved Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
davidhassell and others added 5 commits February 9, 2022 08:40
@davidhassell @sadielbartholomew
Typo
1184eae 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Reword docs
8090413 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Reword docs
131505b 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Reword docs
330bcd0 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
change dtype default for Data.full; update tests
8ab7733
sadielbartholomew
sadielbartholomew approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All previous feedback addressed. All good, thanks.

@sadielbartholomew sadielbartholomew merged commit 1665dd9 into NCAS-CMS:lama-to-dask Feb 9, 2022
@sadielbartholomew
Copy link
Member

I did notice a few missing >>> print(d.array) in the Data.full docstring, but that's so trivial and non-controversial I will add them in as a follow-on commit to save time.

sadielbartholomew added a commit that referenced this pull request Feb 9, 2022
@sadielbartholomew
Minor updates to docstrings from #315
df4d82d
@davidhassell davidhassell deleted the dask-full branch November 15, 2022 09:17
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew