Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data.flatten #333

Merged
merged 3 commits into from
Mar 9, 2022
Merged

dask: Data.flatten #333

merged 3 commits into from
Mar 9, 2022

Conversation

davidhassell
Copy link
Collaborator

No description provided.

@davidhassell davidhassell added the dask Relating to the use of Dask label Mar 1, 2022
@davidhassell davidhassell mentioned this pull request Mar 1, 2022
Closed
sadielbartholomew
sadielbartholomew approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but all good to go, assuming TODODASK - check against daask flatten behaviour has been covered (as per the removed line)?

cf/data/data.py Outdated Show resolved Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
@davidhassell @sadielbartholomew
Typo
8812368 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
Copy link
Collaborator Author

Thanks Sadie - you're right that the TODODASK - check against dask flatten behaviour has been covered. It behaves like numpy in that it doesn't allow subsets of axes to be flattened, so that code that does that (the transposing and reshaping) is still there in Data.flatten.

@davidhassell davidhassell merged commit ee78e19 into NCAS-CMS:lama-to-dask Mar 9, 2022
@davidhassell davidhassell deleted the dask-flatten branch November 15, 2022 09:18
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew