Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data.HDF_chunks #338

Merged
merged 3 commits into from
Mar 18, 2022
Merged

dask: Data.HDF_chunks #338

merged 3 commits into from
Mar 18, 2022

Conversation

davidhassell
Copy link
Collaborator

No dask implications here, just tidying up something that never really got finished from way back.

@davidhassell davidhassell mentioned this pull request Mar 4, 2022
Closed
@davidhassell davidhassell added the dask Relating to the use of Dask label Mar 7, 2022
@davidhassell
Copy link
Collaborator Author

Hi Sadie, I've just noticed that we have nc_clear_hdf5_chunksizes, nc_hdf5_chunksizes, and nc_set_hdf5_chunksizes inherited from cfdm, which might make HDF_chunks redundant. Please don't look at this yet while I see if that's the case. Thanks.

@davidhassell davidhassell marked this pull request as draft March 10, 2022 09:26
@davidhassell
Copy link
Collaborator Author

OK - using the cfdm methods is the way to go, as it's only cfdm.NetCDFWrite that knows how to dealy with the HDF chunk sizes.

@davidhassell
Copy link
Collaborator Author

I've left some uses of HDF_chunks in, as they are in LAMA-based serialisation methods that are not daskified yet and will need a complete overhaul anyway.

@davidhassell davidhassell marked this pull request as ready for review March 10, 2022 09:53
sadielbartholomew
sadielbartholomew approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good (and very dedicated of you to have added new docstring examples to a deprecated method)!

cf/data/data.py Outdated Show resolved Hide resolved
@davidhassell @sadielbartholomew
Typo
aaa0071 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
Copy link
Collaborator Author

Just checking - is good to merge? Thanks.

@sadielbartholomew
Copy link
Member

Just checking - is good to merge? Thanks.

Yes, please go ahead.

@davidhassell davidhassell merged commit 6866ffd into NCAS-CMS:lama-to-dask Mar 18, 2022
@davidhassell davidhassell mentioned this pull request Apr 13, 2022
Merged
@davidhassell davidhassell deleted the dask-HDF-chunks branch November 15, 2022 09:17
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew