Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data units and calendar methods inherited from cfdm #357

Merged
merged 2 commits into from
Mar 22, 2022
Merged

dask: Data units and calendar methods inherited from cfdm #357

merged 2 commits into from
Mar 22, 2022

Conversation

davidhassell
Copy link
Collaborator

units/calendar compatibility with parent cfdm.Data

@davidhassell davidhassell added the dask Relating to the use of Dask label Mar 21, 2022
@davidhassell davidhassell mentioned this pull request Mar 21, 2022
Closed
sadielbartholomew
sadielbartholomew approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, and bonus points for adding new tests (I make it 92 tests with 33 skips at this point, which is great migration progress). Please merge.

@davidhassell davidhassell merged commit 61beb27 into NCAS-CMS:lama-to-dask Mar 22, 2022
@davidhassell davidhassell deleted the dask-units-calendar branch November 15, 2022 09:23
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew