Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data.__hash__ #366

Merged
merged 6 commits into from
Apr 1, 2022
Merged

dask: Data.__hash__ #366

merged 6 commits into from
Apr 1, 2022

Conversation

davidhassell
Copy link
Collaborator

Hi Sadie, I think deprecating __hash__ is the good thing to do because it was never used in the library code; it's exact functionality is still in cf.hash_array; and it was never a good hash of a Data object, anyway, as it it didn't include units, cyclic axes, etc.

@davidhassell davidhassell added the dask Relating to the use of Dask label Mar 30, 2022
@davidhassell davidhassell mentioned this pull request Mar 30, 2022
Closed
@davidhassell davidhassell changed the title dask-hash dask: Data.__hash__ Mar 30, 2022
sadielbartholomew
sadielbartholomew approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments raised in-line for your consideration pre-merge, but this looks solid overall and I agree that deprecating __hash__ seems sensible given your justifications.

cf/data/mixin/deprecations.py Outdated Show resolved Hide resolved
cf/data/mixin/deprecations.py Outdated Show resolved Hide resolved
cf/data/mixin/deprecations.py Outdated Show resolved Hide resolved
cf/functions.py Outdated Show resolved Hide resolved
cf/functions.py Outdated Show resolved Hide resolved
davidhassell and others added 5 commits April 1, 2022 08:31
@davidhassell @sadielbartholomew
Typo
9d4d256 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
ed5a1c7 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
45a1e3b 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
dccdc38 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
deprecation message
8299db6
@davidhassell davidhassell merged commit 906e437 into NCAS-CMS:lama-to-dask Apr 1, 2022
@davidhassell davidhassell deleted the dask-hash branch November 15, 2022 09:22
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew