Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dask: Data.__round__ #370

Merged
merged 4 commits into from
Apr 20, 2022
Merged

Conversation

davidhassell
Copy link
Collaborator

__round__ is not implemented by numpy nor dask - I reckon it's OK to also not implement it here.

@davidhassell davidhassell added the dask Relating to the use of Dask label Apr 4, 2022
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue, as raised in-line, otherwise this looks good to me.

cf/data/mixin/deprecations.py Outdated Show resolved Hide resolved
cf/data/mixin/deprecations.py Outdated Show resolved Hide resolved
davidhassell and others added 2 commits April 5, 2022 08:21
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
Copy link
Collaborator Author

Hi Sadie - just checking if this is good to merge, now?

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Apr 20, 2022

Hi Sadie - just checking if this is good to merge, now?

Yes, good to go in my eyes; sorry I realise now I had left this on a 'Changes requested' state by accident. Thanks.

@davidhassell davidhassell merged commit 6b8bfea into NCAS-CMS:lama-to-dask Apr 20, 2022
@davidhassell davidhassell deleted the dask-round branch November 15, 2022 09:22
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Relating to the use of Dask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants