Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dask: Data.uncompress #385

Merged
merged 8 commits into from
Apr 20, 2022

Conversation

davidhassell
Copy link
Collaborator

No description provided.

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, with one typo raised in-line. Whilst considering this method overall, I also see there's a docs typo in lines untouched by this PR: "The uncompressed data, or None of the operation was". Ideally we can fix that here too. Once those are sorted, feel free to merge. Thanks.

cf/data/data.py Outdated Show resolved Hide resolved
davidhassell and others added 2 commits April 20, 2022 20:39
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
Copy link
Collaborator Author

Fixed of -> if. Merging.

@davidhassell davidhassell changed the title Dask uncompress dask: Data.uncompress Apr 20, 2022
@davidhassell davidhassell merged commit 2fc1595 into NCAS-CMS:lama-to-dask Apr 20, 2022
@davidhassell davidhassell deleted the dask-uncompress branch November 15, 2022 09:20
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Relating to the use of Dask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants