Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data.varray #397

Merged
merged 5 commits into from
May 9, 2022
Merged

dask: Data.varray #397

merged 5 commits into from
May 9, 2022

Conversation

davidhassell
Copy link
Collaborator

Properly deprecates varray. There is no generally safe alternative in the dask world.

Also does a bit of unrelated tidying in deprecations.py.

@davidhassell davidhassell added the dask Relating to the use of Dask label Apr 27, 2022
@davidhassell davidhassell mentioned this pull request Apr 27, 2022
Closed
sadielbartholomew
sadielbartholomew approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sound, though I have raised one question relating to the status of local test results I am seeing (probably nothing of concern) and one typo. Good to merge once those are considered. Thanks.

cf/data/mixin/deprecations.py Outdated Show resolved Hide resolved
cf/data/mixin/deprecations.py Outdated Show resolved Hide resolved
cf/data/data.py Show resolved Hide resolved
davidhassell and others added 2 commits May 6, 2022 19:34
@davidhassell @sadielbartholomew
Typo
d733ae1 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
4b64cfe 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
sadielbartholomew
sadielbartholomew approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Please merge.

@davidhassell davidhassell merged commit 202255d into NCAS-CMS:lama-to-dask May 9, 2022
@davidhassell davidhassell changed the title dask: Dask.varray dask: Data.varray May 16, 2022
@davidhassell davidhassell deleted the dask-varray branch November 15, 2022 09:26
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew