LAMA to Dask: (deprecate) Data.concatenate_data
#426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating the
Data.concatenate_data
method towards #182, by deprecating it.I don't think this approach will be controversial (so-as to have required pre-PR discussion) since it seems to be essentially the same method as
concatenate
, just compare the inputs and outputs on the docstrings to see this, with no real difference except for the behaviour of:and it is not used anywhere throughout the codebase, unlike
concatenate
which is used quite widely (note this was a post-PR grep, but regardless the only usage is to define it):Anyhow @davidhassell you can object at this stage and close if there is a justification to keep the method, else review this towards merging, as the change itself is almost trivial. Thanks.