Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Field.where #464

Merged
merged 3 commits into from
Oct 26, 2022
Merged

dask: Field.where #464

merged 3 commits into from
Oct 26, 2022

Conversation

davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Oct 12, 2022 •
edited
Loading

A bit of a tidy, and a change to Data.where to allow leading size one dimensions. Deleted the _broadcast function as it is not used.

@davidhassell davidhassell added the dask Relating to the use of Dask label Oct 12, 2022
sadielbartholomew
sadielbartholomew approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks, with sensible updates and test_Field_where now passing locally for me. I've raised a few typos but other than that this is good to merge.

cf/data/data.py Outdated Show resolved Hide resolved
cf/field.py Outdated Show resolved Hide resolved
davidhassell and others added 2 commits October 26, 2022 15:05
@davidhassell @sadielbartholomew
Typo
41b22a9 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
0b37fa8 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell davidhassell merged commit 8908b9f into NCAS-CMS:lama-to-dask Oct 26, 2022
@davidhassell davidhassell deleted the dask-field-where branch November 15, 2022 09:29
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
@davidhassell davidhassell mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew