dask: Deprecate close

[davidhassell]

Deprecates close methods, and removes the corresponding tests.

[sadielbartholomew]

Close, but no cigar! 😆 Feel free to apply the recurrent change suggested yourself rather than via my 'suggestion' set if that's more convenient, but I've made them as suggestions in case that is simplest.

Is there a location we can put some brief testing on deprecated keywords such as this, since nothing failed in the test suite despite the consistent invalid keyword argument here, and it would be good to catch basic issues like that?

[sadielbartholomew]

[Intended to set this as my judgement in the review I just submitted...]

[davidhassell]

Is there a location we can put some brief testing on deprecated keywords such as this, since nothing failed in the test suite despite the consistent invalid keyword argument here, and it would be good to catch basic issues like that?

Hi Sadie, good idea. Not yet - I suppose a new file test_deprecated.py might be a good place to put them, from where they can easily be deleted once the removed_at version is reached.

[sadielbartholomew]

I suppose a new file test_deprecated.py might be a good place to put them, from where they can easily be deleted once the removed_at version is reached.

Sounds like a good plan to me. Shall we bump it to a new issue, since the Dask migration takes priority I am sure?

[davidhassell]

Shall we bump it to a new issue, since the Dask migration takes priority I am sure?
Agreed - I'll make one.

Is this good to merge, now?

[sadielbartholomew]

Feedback all addressed. All good now, please merge.