Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Deal with TODODASKDOCS placeholders #540

Merged
merged 12 commits into from
Jan 26, 2023
Merged

dask: Deal with TODODASKDOCS placeholders #540

merged 12 commits into from
Jan 26, 2023

Conversation

davidhassell
Copy link
Collaborator

Deal with TODODASKDOCS placeholders.

@davidhassell davidhassell added low priority dask Relating to the use of Dask labels Dec 22, 2022
@davidhassell davidhassell added this to the 3.14.0 milestone Dec 22, 2022
@davidhassell davidhassell linked an issue Jan 4, 2023 that may be closed by this pull request
LAMA to Dask: address TODODASK items #433
Closed
sadielbartholomew
sadielbartholomew approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clarifications and examples. Some typos but otherwise all good, so please merge once they are addressed.

cf/data/array/umarray.py Outdated Show resolved Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
cf/mixin/propertiesdata.py Outdated Show resolved Hide resolved
cf/mixin/propertiesdata.py Outdated Show resolved Hide resolved
davidhassell and others added 6 commits January 26, 2023 17:11
@davidhassell @sadielbartholomew
Typo
76de22c 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
de0aa4d 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
0e5e369 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
56cc058 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
f59c023 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
34196e4 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
Copy link
Collaborator Author

Thanks Sadie, a higher than usual count of sloppy typing on my part, I think - sorry!

@davidhassell davidhassell merged commit df588ed into NCAS-CMS:lama-to-dask Jan 26, 2023
@davidhassell davidhassell deleted the dask-TODODASKDOCS branch January 26, 2023 17:14
@sadielbartholomew
Copy link
Member

a higher than usual count of sloppy typing on my part, I think - sorry!

Not at all, typos are inevitable with the amount of line changes you are making (and I secretly like the typos because I get an easy commit if you accept the suggestion 😉 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask low priority
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

LAMA to Dask: address TODODASK items
2 participants
@davidhassell @sadielbartholomew