Fix for print when no dimension coordinate data #175
Conversation
|
(seems like I updated a joss bibtex date - by mistake? I'm not sure. We can let it go through and I'll sort it out with a commit afterwards ...) |
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 88.71% 88.72% +0.02%
==========================================
Files 101 101
Lines 10805 10806 +1
==========================================
+ Hits 9585 9587 +2
+ Misses 1220 1219 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Perfect, thanks. Please merge.
In reviewing, I went to also check that deleting the data from any of the other constructs that take data wouldn't cause the __str__ output to error, and indeed they don't cause any issues (I checked for an auxiliary coordinate, field ancillary, cell measure and domain ancillary), so I agree with your identification that only the deletion of dimension coordinates' data caused issue (despite my issue write-up implying it could be a more general issue).
Still, if they aren't covered elsewhere, maybe we could add in some equivalent testing to the small block you added to 'test_Domain' under 'Test when dimension coordinate has no data' to cover those other constructs no having data? I can do that as a follow-up commit or PR, unless you want to add it in here?
|
Thanks, Sadie - let's do as you suggest in a follow up PR. |
Fixes #174