-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge Botulinum toxin A nodes #395
Comments
PK : 1fb6945c-668b-4750-85f4-2daa53eb4596 |
Output of Name resolver
|
@cbizon : This is not a conflation issue but a normalization one. |
from TAQA: two cliques for BTA - one has all the usual IDs, one has just UMLS (hard to map UMLS to the rest); move this to Fall because not an easy fix. Could be drug conflator is the issue here. |
This should be conflated by the Drug Conflator -- as you can see in https://nodenormalization-dev.apps.renci.org/1.4/get_normalized_nodes?curie=UMLS%3AC0006050&curie=UNII%3AE211KPY694&conflate=true&drug_chemical_conflate=true, UMLS:C0006050 is listed as an alternate ID for UNII:E211KPY694, and it's not clear why that isn't happening. I am investigating. |
@gaurav this is still any issue - who should this go to? |
This is still on me. The problem is that UMLS:C0006050 is a Protein while UNII:E211KPY694 is a ChemicalEntity, which are handled separately in Babel and so they won't be combined as-is. I'm still thinking about how best to combine them, as I don't know any source of UNII-protein connections (TranslatorSRI/Babel#164). I'm also annoyed that it is possible to have the same identifier in multiple cliques because of how NodeNorm's databases are designed, but that's out of scope for this issue and possibly for this year (TranslatorSRI/Babel#276). |
Without drug conflation, we now have 8 cliques:
So we're definitely doing better, but we still have some UMLS terms we need to combine, which is a pretty high priority for us (TranslatorSRI/Babel#302). I'll try to have this fixed by Guppy. |
I'm pushing all protein/chemical combination work into Hammerhead. Plus, adding a manual conflation to proteins turns out to be trickier than adding a manual conflation to chemical entities. |
in Hammerhead release on Test: https://ui.test.transltr.io/results?l=Bethlem%20Myopathy&i=MONDO:0008029&t=0&r=0&q=bc5a5d5e-6b8f-4f73-bf74-a2e1c2af46b7 One result for Botulinum Toxin Type A. Four results for Botulinum. @gaurav are you expecting any other changes for name resolver for this issue or can we consider it closed? |
Type: Bug Report
URL: https://ui.ci.transltr.io/results?l=Bethlem%20Myopathy&i=MONDO:0008029&t=0&q=1fb6945c-668b-4750-85f4-2daa53eb4596
ARS PK: 98ca4253-5d0e-4741-9ace-0e051a37c0c7
Steps to reproduce:
CI environment
MVP1 Bethlem disease
Screenshots:
The text was updated successfully, but these errors were encountered: