Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax error in RetrievalSource #393

Merged
merged 8 commits into from
Mar 21, 2023
Merged

fix syntax error in RetrievalSource #393

merged 8 commits into from
Mar 21, 2023

Conversation

sierra-moxon
Copy link
Member

No description provided.

adding resourcerole as an object to reference so that it can have a m…
@vdancik vdancik added this to the v1.4 milestone Feb 1, 2023
@mbrush
Copy link
Collaborator

mbrush commented Feb 2, 2023

This PR replaces #388 (which has been closed - go there for history of edits/comments up to this point).

The current PR 393 includes all content from that PR, plus fixes syntax errors, and adds an enumeration that is bound to the RetrievalSource.resource_role property.

added RetrievalSource.source_record_urls property, per #392.
@mbrush
Copy link
Collaborator

mbrush commented Mar 9, 2023

I added a source_record_urls property to address #392.

fixing string type declaration on RetrievalSource.source_record_urls property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants