Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert gcse-cs-support page to Strapi #2262

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Conversation

A-Wheeto
Copy link
Contributor

@A-Wheeto A-Wheeto commented Dec 31, 2024

Status

Review progress:

  • Browser tested
  • Front-end review completed
  • Tech review completed

What's changed?

  • Added optional sub text for cms_card_wrapper component
  • Updated CMS testimonial component to show text colour based on background colour via application helper
  • Removed old hard coded page
  • Removed old page route
  • Updated all links to gcse-cs-support to cms_page

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2262 December 31, 2024 11:15 Inactive
@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2262 January 2, 2025 10:24 Inactive
@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2262 January 2, 2025 15:01 Inactive
@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2262 January 2, 2025 15:20 Inactive
@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2262 January 2, 2025 15:56 Inactive
Copy link
Contributor

@msquance-stem msquance-stem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2262 January 8, 2025 08:10 Inactive
@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2262 January 8, 2025 09:07 Inactive
@A-Wheeto A-Wheeto force-pushed the 2751-convert-gcse-cs-support branch from 3e572fc to b087183 Compare February 3, 2025 15:06
@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2262 February 3, 2025 15:18 Inactive
Updated testing to cover this
Removed old route for gcse-cs-support page
Updated links across the site to go to new cms page
Removed old hard coded page
Added test for application helper
@A-Wheeto A-Wheeto force-pushed the 2751-convert-gcse-cs-support branch from b087183 to c3f2ca2 Compare February 6, 2025 09:58
@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2262 February 6, 2025 09:58 Inactive
Copy link

sonarqubecloud bot commented Feb 6, 2025

@A-Wheeto A-Wheeto merged commit ed14b11 into main Feb 6, 2025
8 checks passed
@A-Wheeto A-Wheeto deleted the 2751-convert-gcse-cs-support branch February 6, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants