Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMS Factory refactor #2265

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CMS Factory refactor #2265

wants to merge 3 commits into from

Conversation

A-Wheeto
Copy link
Contributor

@A-Wheeto A-Wheeto commented Jan 15, 2025 •
edited
Loading

Status

Review progress:

  • Browser tested
  • Front-end review completed
  • Tech review completed

What's changed?

  • Refactored factories into new base_factory, button_factory, blocks_factory, content_block_factory for better readability
  • Refactored some cms component tests
  • General tidy up of the factories

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2265 January 15, 2025 10:40 Inactive
@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2265 January 15, 2025 15:28 Inactive
@A-Wheeto
Added new base factory module to clean up and separate components
8a5f57d 
Refactored factories and general tidy up
Fixing tests
@A-Wheeto
Set with_wrapper on text block to true by default
519c128 
Rename and refactor to_icon
@A-Wheeto A-Wheeto force-pushed the 2934-cms-factory-refactor branch from 3e88fcb to 519c128 Compare February 3, 2025 15:29
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A-Wheeto @tc-deploybot