CMS View Component Tidy #2266
Open
CMS View Component Tidy #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msquance-stem
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Is it worth adding in preview for video and image in here too?
There was a problem hiding this comment.
Great idea, I will add this into a preview.
Moved into CMS namespace Updated tests Updated previews Refactored code where needed
Refactor previews and tests Create files for missing previews
Tidy up exisiting previews Fix broken previews
Remove empty connect method Remove duplicate CSS class
A-Wheeto
force-pushed
the
2933-cms-viewcomponent-tidy-up
branch
from
abb8169 to
cbead70
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved into CMS namespace
Updated tests
Updated previews
Refactored code where needed
Status
Review progress:
What's changed?
Description of what's been done - bullets are usually best, but you do you.
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.