-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should annotations be able to have id
attributes?
#335
Comments
Aside from what you've outlined here, when it comes to building a UI around adding, updating, and removing annotations, having an |
Would the id go on the
|
@twhiteaker - this suggestion means that there would be an id attribute on both elements.
|
Hey @twhiteaker, my fault: I had the left those details out of the XML snippets. I think I fixed them and they match what @mobb said. Sorry about that! |
Makes sense to me |
Okay I pushed this up to the 2.2.0 branch. You can now put id, system, and scope on your annotation elements, like: <annotation id="myanno" system="earth" scope="document">
<propertyURI label="Subject">http://purl.org/dc/elements/1.1/subject</propertyURI>
<valueURI label="grassland biome">http://purl.obolibrary.org/obo/ENVO_01000177</valueURI>
</annotation> Will leave open until we merge with master or someone else closes for their own issue-managing workflow. |
@mpsaloha brought up an interesting point last week on our DataONE semprov call: Should
<annotation>
elements be able to haveid
s? This'd allow at least two cool things:For example, (2) allows us to insert provenance about annotations. Take this annotation:
Add in the option of an
id
attribute:I think this is potentially useful, and I also think it's not a problem to add to the schema and it's probably better to add now, before 2.2 is released. @mobb mentioned our usual pattern with
id
attributes is that they also come withsystem
andscope
attributes, like:Is this interesting to others and does this fit within the spirit of the semantics module?
The text was updated successfully, but these errors were encountered: