Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the metrics display across all the themes #642

Closed
rushirajnenuji opened this issue Jun 7, 2018 · 3 comments
Closed

Test the metrics display across all the themes #642

rushirajnenuji opened this issue Jun 7, 2018 · 3 comments
Assignees
@rushirajnenuji
Labels
metrics Tickets for buiilding and maintaining metrics displays metrics-display
Milestone
2.1.0

Comments

@rushirajnenuji
Copy link
Member

No description provided.

@rushirajnenuji rushirajnenuji self-assigned this Jun 7, 2018
@rushirajnenuji rushirajnenuji added metrics Tickets for buiilding and maintaining metrics displays metrics-display next labels Jun 7, 2018
@rushirajnenuji
Copy link
Member Author

rushirajnenuji commented Jun 7, 2018 •
edited
Loading

Test the metrics display across all the themes:

  • Default

  • DataONE

  • KNB

  • Arctic

rushirajnenuji added a commit that referenced this issue Jun 11, 2018
@rushirajnenuji
Adding the metadata controls and the owner controls in the metrics well.
ff36f6f 
Adding the metadata controls and the owner controls in the metrics well.

TODO: The Success message on copy citation button.
TODO: Discuss current styling with the team.

Refernce : #594 , #641 , #642
rushirajnenuji added a commit that referenced this issue Jun 18, 2018
@rushirajnenuji
Making all the themes consistent w.r.t. styling.
7baad2d 
- Making all the themes consistent w.r.t. styling.
- Removing styles from the Metrics well

Reference: #641 #642
rushirajnenuji added a commit that referenced this issue Jun 22, 2018
@rushirajnenuji
CSS Changes for the metrics-well. Keeping themes consistenet
eda2bf2 
Reference: #642

Specific Changes include:
 - Arctic theme: making width header equal to the conetnt section.
 - KNB, Arctic : Modifying button spacing.
 - All themes: Adding tootlip on the dataset landing page.
@rushirajnenuji
Copy link
Member Author

In MDC dev meeting on June 21, @laurenwalker and I did some manual testing of the metrics display. Couple of suggestions were:

  • Adding a tooltip on landing page metrics based on the message that we display on the Metrics Modals (Refer UI mock-ups here)
  • Modify width of Arctic theme's header.
  • Buttons spacing in Arctic and KNB themes.

Solved with the commit: eda2bf2

@laurenwalker laurenwalker added this to the 2.1.0 milestone Jul 11, 2018
@rushirajnenuji
Copy link
Member Author

Tested the metrics display across all the themes, with and without the metrics-display enabled. Right now we've decided to disable the display till we've enough information in ES to drive the UI.

  • Some UI changes that were suggested were made in the commit eda2bf2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rushirajnenuji rushirajnenuji

Labels
metrics Tickets for buiilding and maintaining metrics displays metrics-display
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@laurenwalker @rushirajnenuji