fix(data-package-view): ensure all subfolders with the same name are created #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…created Previously, the `addFilesAndFolders` function did not correctly handle the creation of subfolders with the same name. This fix ensures that all subfolders are created properly by constructing the full path for each folder and checking against the `pathMap` to avoid duplicates. - Updated the `addFilesAndFolders` function to construct the full path for each folder. - Ensured that the `pathMap` is updated with the correct paths for all subfolders. - Added detailed comments to the `addFilesAndFolders` function for better readability and maintenance. This resolves the issue where subfolders with the same name were not being created correctly. Closes NCEAS#2442
|
@robyngit @rushirajnenuji let me know if you have any questions. I am happy to work with you to get this resolved. This is a critical fix for us as we will not be able to offer support for hierarchical dataset viewing until this is resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
addFilesAndFoldersfunction did not correctly handle the creation of subfolders with the same name. This fix ensures that all subfolders are created properly by constructing the full path for each folder and checking against thepathMapto avoid duplicates.addFilesAndFoldersfunction to construct the full path for each folder.pathMapis updated with the correct paths for all subfolders.addFilesAndFoldersfunction for better readability and maintenance.This resolves the issue where subfolders with the same name were not being created correctly.
Closes #2442