-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize shortName element in EML #2591
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [eslint] <no-var> reported by reviewdog 🐶 metacatui/src/js/models/metadata/eml211/EML211.js Lines 53 to 2634 in dae8989
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [eslint] <object-shorthand> reported by reviewdog 🐶 metacatui/src/js/models/metadata/eml211/EML211.js Lines 744 to 1224 in dae8989
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -775,8 +775,8 @@ define([ | |
|
||
var nodeNameMap = this.nodeNameMap(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [eslint] <vars-on-top> reported by reviewdog 🐶 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶 |
||
|
||
//Serialize the basic text fields | ||
var basicText = ["alternateIdentifier", "title"]; | ||
// Serialize the basic text fields | ||
const basicText = ["alternateIdentifier", "title", "shortName"]; | ||
_.each( | ||
basicText, | ||
function (fieldName) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prefer-arrow-callback> reported by reviewdog 🐶
Unexpected function expression.
metacatui/src/js/models/metadata/eml211/EML211.js
Lines 23 to 2637 in dae8989