-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report "attended and submitted" #159
Comments
Answering @evdhoudt 's slack questions here, so that @dspCarlson can also take a look: |
Q: What date should be used for the submitted reports? Since there is no submitted_at date. At the I use the created_at date for the grouping and past the DRAFT state. Q: Should all report states be included? Q: What report state should be filtered by to get engagements attended? At the moment I use report state RELEASED. However, when a report is in DRAFT or anything else except cancelled, the engagement could still have gone trough… Q: Basically the question is, how are the reports currently compiled so we are able to reproduce the same statistics? |
Provides components to visualize Reports submitted and Engagements attended for advisors of a given organization. Changes to be committed: new file: client/src/components/AdvisorReports/AdvisorReportsModal.js new file: client/src/components/AdvisorReports/AdvisorReportsRow.js new file: client/src/components/AdvisorReports/AdvisorReportsTable.js new file: client/src/components/AdvisorReports/AdvisorReportsTableHead.js new file: client/src/components/AdvisorReports/FilterableAdvisorReportsTable.js new file: client/src/components/AdvisorReports/OrganizationAdvisorsTable.css new file: client/src/components/AdvisorReports/OrganizationAdvisorsTable.js new file: client/src/components/AdvisorReports/Toolbar.js
Changes to be committed: modified: client/src/components/AdvisorReports/FilterableAdvisorReportsTable.js
Changes to be committed: modified: client/src/components/AdvisorReports/FilterableAdvisorReportsTable.js modified: client/src/components/AdvisorReports/Toolbar.js
modified: client/src/components/AdvisorReports/OrganizationAdvisorsTable.js
query Changes to be committed: modified: src/main/java/mil/dds/anet/database/ReportDao.java
Changes to be committed: modified: src/components/AdvisorReports/AdvisorReportsRow.js modified: src/components/AdvisorReports/AdvisorReportsTable.js modified: src/components/AdvisorReports/FilterableAdvisorReportsTable.js modified: src/components/AdvisorReports/OrganizationAdvisorsTable.js
Changes to be committed: modified: package.json modified: src/components/AdvisorReports/AdvisorReportsRow.js
data per organization Changes to be committed: modified: src/components/AdvisorReports/AdvisorReportsModal.js modified: src/components/AdvisorReports/AdvisorReportsTable.js modified: src/components/AdvisorReports/AdvisorReportsTableHead.js modified: src/components/AdvisorReports/FilterableAdvisorReportsTable.js modified: src/components/AdvisorReports/OrganizationAdvisorsTable.js modified: src/components/SimpleModal.js modified: ../src/main/java/mil/dds/anet/database/ReportDao.java modified: ../src/main/java/mil/dds/anet/resources/ReportResource.java
Remove almost duplicate advisor report query method and combine query parameters with string replacements triggered when an organization is set in the query params. Changes to be committed: modified: ../src/main/java/mil/dds/anet/database/ReportDao.java modified: ../src/main/java/mil/dds/anet/resources/ReportResource.java
objects Changes to be committed: modified: client/src/components/AdvisorReports/FilterableAdvisorReportsTable.js modified: client/src/components/AdvisorReports/OrganizationAdvisorsTable.js
Changes to be committed: modified: client/src/components/AdvisorReports/AdvisorReportsModal.js modified: client/src/components/AdvisorReports/OrganizationAdvisorsTable.css
Changes to be committed: modified: src/components/AdvisorReports/AdvisorReportsModal.js modified: src/components/AdvisorReports/AdvisorReportsRow.js modified: src/components/AdvisorReports/AdvisorReportsTable.js modified: src/components/AdvisorReports/AdvisorReportsTableHead.js modified: src/components/AdvisorReports/FilterableAdvisorReportsTable.js modified: src/components/AdvisorReports/OrganizationAdvisorsTable.js
Changes to be committed: modified: src/components/AdvisorReports/AdvisorReportsRow.js modified: src/components/AdvisorReports/FilterableAdvisorReportsTable.js
Now shows a correct example for a grouped list
One organization currently complies by hand a table of the engagements attended by their advisors and the number of engagement reports that they submit over a week. This is a very useful management tool for them, automating it would save their staff several hours of work a week.
Visible only to super users and admins at this time
Essential:
Nice to have
Examples:
on request
The text was updated successfully, but these errors were encountered: