Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report "attended and submitted" #159

Closed
VassilIordanov opened this issue Aug 29, 2017 · 2 comments
Closed

Report "attended and submitted" #159

VassilIordanov opened this issue Aug 29, 2017 · 2 comments
Assignees
Labels

Comments

@VassilIordanov
Copy link
Contributor

VassilIordanov commented Aug 29, 2017

One organization currently complies by hand a table of the engagements attended by their advisors and the number of engagement reports that they submit over a week. This is a very useful management tool for them, automating it would save their staff several hours of work a week.

Visible only to super users and admins at this time

Essential:

  • Must be sortable by organisation and displayed in tabular format.

Nice to have

  • export to CSV/EXCEL functionality

Examples:

on request

@VassilIordanov VassilIordanov changed the title Report engagements attended and reports submitted Report "attended and submitted" Aug 29, 2017
@evdhoudt evdhoudt self-assigned this Aug 31, 2017
@VassilIordanov
Copy link
Contributor Author

VassilIordanov commented Sep 12, 2017

Answering @evdhoudt 's slack questions here, so that @dspCarlson can also take a look:
Q: What date should be used for the submitted reports? Since there is no submitted_at date. At the I use the created_at date for the grouping and past the DRAFT state.
A: created_at is good
Q: Should all report states be included?
A: I would say yes
Q: What report state should be filtered by to get engagements attended? At the moment I use report state RELEASED. However, when a report is in DRAFT or anything else except cancelled, the engagement could still have gone trough…
A: I would say it can be in any state except cancelled or DRAFT. @dspCarlson , can you confirm please
Q: Basically the question is, how are the reports currently compiled so we are able to reproduce the same statistics?
A: I'll try to figure it out, @dspCarlson - any ideas?

@dspCarlson
Copy link

Q: What date should be used for the submitted reports? Since there is no submitted_at date. At the I use the created_at date for the grouping and past the DRAFT state.
A: I agree with @VassilIordanov The created_at field is the only field to use because there is not a submitted_at field. On our side there is proposal (item 88) to create a submitted_at field. The users are asking for this date to keep report authors accountable.

Q: Should all report states be included?
A: Yes. There is a future issue and a past issue to resolve with reports. Future Issue: Which approver(s) need to approve the report? They are holding up the report being released. Past Issue: Who approved the report and when? Approvers sometimes approve the wrong report or the approvers take too long to approve. Approval chain steps can have 20 people because each organization is only allowed one approval chain yet different approvers need to approve different type of reports.

Q: What report state should be filtered by to get engagements attended? At the moment I use report state RELEASED. However, when a report is in DRAFT or anything else except cancelled, the engagement could still have gone trough…
A: I agree with @VassilIordanov Cancelled and Draft states should not be included in engagements attended.

Q: Basically the question is, how are the reports currently compiled so we are able to reproduce the same statistics?
A: There are two scenarios I can think of: Scenario 1: Organizations want to know how many reports were written (draft, pending or released) during a given period of time and then compare to how many actual engagement there were during the same period of time. Scenario 2: Organizations want to know how many reports were released during a given period of time. Believe it or not, organizations compare themselves to other organizations. It's almost like the organizations have a competition among themselves.

evdhoudt added a commit that referenced this issue Oct 9, 2017
evdhoudt added a commit that referenced this issue Oct 9, 2017
evdhoudt added a commit that referenced this issue Oct 9, 2017
Provides components to visualize Reports submitted and
Engagements attended for advisors of a given organization.

Changes to be committed:
	new file:   client/src/components/AdvisorReports/AdvisorReportsModal.js
	new file:   client/src/components/AdvisorReports/AdvisorReportsRow.js
	new file:   client/src/components/AdvisorReports/AdvisorReportsTable.js
	new file:   client/src/components/AdvisorReports/AdvisorReportsTableHead.js
	new file:   client/src/components/AdvisorReports/FilterableAdvisorReportsTable.js
	new file:   client/src/components/AdvisorReports/OrganizationAdvisorsTable.css
	new file:   client/src/components/AdvisorReports/OrganizationAdvisorsTable.js
	new file:   client/src/components/AdvisorReports/Toolbar.js
evdhoudt added a commit that referenced this issue Oct 9, 2017
Changes to be committed:
	modified:   client/src/components/AdvisorReports/FilterableAdvisorReportsTable.js
evdhoudt added a commit that referenced this issue Oct 9, 2017
Changes to be committed:
	modified:   client/src/components/AdvisorReports/FilterableAdvisorReportsTable.js
	modified:   client/src/components/AdvisorReports/Toolbar.js
evdhoudt added a commit that referenced this issue Oct 9, 2017
	modified:   client/src/components/AdvisorReports/OrganizationAdvisorsTable.js
evdhoudt added a commit that referenced this issue Oct 9, 2017
query

Changes to be committed:
	modified:   src/main/java/mil/dds/anet/database/ReportDao.java
evdhoudt added a commit that referenced this issue Oct 9, 2017
Changes to be committed:
	modified:   src/components/AdvisorReports/AdvisorReportsRow.js
	modified:   src/components/AdvisorReports/AdvisorReportsTable.js
	modified:   src/components/AdvisorReports/FilterableAdvisorReportsTable.js
	modified:   src/components/AdvisorReports/OrganizationAdvisorsTable.js
evdhoudt added a commit that referenced this issue Oct 9, 2017
Changes to be committed:
	modified:   package.json
	modified:   src/components/AdvisorReports/AdvisorReportsRow.js
evdhoudt added a commit that referenced this issue Oct 9, 2017
data per organization

Changes to be committed:
	modified:   src/components/AdvisorReports/AdvisorReportsModal.js
	modified:   src/components/AdvisorReports/AdvisorReportsTable.js
	modified:   src/components/AdvisorReports/AdvisorReportsTableHead.js
	modified:   src/components/AdvisorReports/FilterableAdvisorReportsTable.js
	modified:   src/components/AdvisorReports/OrganizationAdvisorsTable.js
	modified:   src/components/SimpleModal.js
	modified:   ../src/main/java/mil/dds/anet/database/ReportDao.java
	modified:   ../src/main/java/mil/dds/anet/resources/ReportResource.java
evdhoudt added a commit that referenced this issue Oct 9, 2017
Remove almost duplicate advisor report query method and combine query
parameters with string replacements triggered when an organization is
set in the query params.

Changes to be committed:
	modified:   ../src/main/java/mil/dds/anet/database/ReportDao.java
	modified:   ../src/main/java/mil/dds/anet/resources/ReportResource.java
evdhoudt added a commit that referenced this issue Oct 9, 2017
objects

Changes to be committed:
	modified:   client/src/components/AdvisorReports/FilterableAdvisorReportsTable.js
	modified:   client/src/components/AdvisorReports/OrganizationAdvisorsTable.js
evdhoudt added a commit that referenced this issue Oct 9, 2017
evdhoudt added a commit that referenced this issue Oct 9, 2017
Changes to be committed:
	modified:   client/src/components/AdvisorReports/AdvisorReportsModal.js
	modified:   client/src/components/AdvisorReports/OrganizationAdvisorsTable.css
evdhoudt added a commit that referenced this issue Oct 12, 2017
Changes to be committed:
	modified:   src/components/AdvisorReports/AdvisorReportsModal.js
	modified:   src/components/AdvisorReports/AdvisorReportsRow.js
	modified:   src/components/AdvisorReports/AdvisorReportsTable.js
	modified:   src/components/AdvisorReports/AdvisorReportsTableHead.js
	modified:   src/components/AdvisorReports/FilterableAdvisorReportsTable.js
	modified:   src/components/AdvisorReports/OrganizationAdvisorsTable.js
evdhoudt added a commit that referenced this issue Oct 12, 2017
Changes to be committed:
	modified:   src/components/AdvisorReports/AdvisorReportsRow.js
	modified:   src/components/AdvisorReports/FilterableAdvisorReportsTable.js
evdhoudt added a commit that referenced this issue Oct 12, 2017
Now shows a correct example for a grouped list
gjvoosten added a commit that referenced this issue Oct 19, 2017
evdhoudt added a commit that referenced this issue Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants