Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hierarchical view of objectives #5048

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jlnat
Copy link
Collaborator

@jlnat jlnat commented Jan 9, 2025

Closes AB#1221

User changes

  • Users should be able to see a new menu entry "Objectives", that displays the objectives at the highest level, and allows navigating to their descendants

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • application.yml or anet-dictionary.yml needs change
    Add a new label:
    fields:
      task:
        allTasksLabel: Objectives
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • described the user behavior in PR body
  • referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • added and/or updated unit tests
  • added and/or updated e2e tests
  • added and/or updated data migrations
  • updated documentation
  • resolved all build errors and warnings
  • opened debt issues for anything not resolved here

@jlnat jlnat requested review from gjvoosten and midmarch January 9, 2025 20:19
anet-dictionary.yml Outdated Show resolved Hide resolved
@jlnat jlnat force-pushed the AB-1221-hierarchical-view-of-objectives branch from 884244d to 9b3e819 Compare January 14, 2025 09:03
@gjvoosten gjvoosten force-pushed the AB-1221-hierarchical-view-of-objectives branch 2 times, most recently from 520a7f1 to bbcec02 Compare February 5, 2025 14:11
@gjvoosten gjvoosten requested a review from midmarch February 5, 2025 14:16
@gjvoosten gjvoosten force-pushed the AB-1221-hierarchical-view-of-objectives branch from bbcec02 to 30ed6a1 Compare February 6, 2025 07:45
@gjvoosten gjvoosten force-pushed the AB-1221-hierarchical-view-of-objectives branch from 30ed6a1 to 063d9c7 Compare February 6, 2025 09:32
@gjvoosten gjvoosten force-pushed the AB-1221-hierarchical-view-of-objectives branch from 063d9c7 to 22f78df Compare February 6, 2025 11:02
anet-dictionary.yml Outdated Show resolved Hide resolved
@midmarch
Copy link
Contributor

midmarch commented Feb 6, 2025

Awesome!

image

When passing "-1" as the parentTaskUuid, search for tasks that don't
have a parent.
Move to components.
Remove the need to fetch data inside the component.
Use different icons for the nodes in the tree to reflect their state.
Show the Task icon in front of each item.
Use a reducer for updating the tree.
Only fetch top-level tasks.
Retrieve all data needed to build the tree in one GraphQL request.
Use standard boilerplating.
Add page title.
Show task tree inside a Fieldset with a proper heading.
@gjvoosten gjvoosten force-pushed the AB-1221-hierarchical-view-of-objectives branch from 22f78df to b6670d8 Compare February 6, 2025 15:05
@gjvoosten gjvoosten requested a review from midmarch February 6, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants