Ticket/4464 imageless cards

[dev-rana-publicis]

Closes #4464

[bryanpizzillo]

@dev-rana-publicis can you please put the imageless cards into cgov_promo with the feature cards? The row can stay in home landing like they do now.

[cgdp-management-server]

ODE Deployment

Code has been deployed to ODE 848.

[welshja]

@dlescarbeau - Everything is working from an analytics perspective as defined on the ticket, but seeing a change that had been discussed, though didn't get translated onto the github ticket. This is the change we'd like to make with the analytics:

componentVariant: This should be set based on the layout selected by the user. This should be set to 1 Card Row, 2 Card Row or 3 Card Row.

Currently the componentVariant value is set to none.

Sorry for the mixup on this.

[KateMashkinaNIH]

1. Machine name should be replaced by "Card Layout Display" per AC and value to default to "3 colums"
   
2. Edit option should not be there for Internal Card

3. Cards width is different in the manually created MLP

[monika-jaeger]

The spacing below the card title is still on the imageless and defaults cards when there is no description.
I don’t see we have comps defined for default & imageless cards with a title only, but we do for flag cards, so we’d want all cards to be consistent. (this might be a separate CR to address all)

[adrianacastaneda]

@dlescarbeau Label for the card display field should be "Card Layout Display" and it should be above the Heading field. Thank you!

Updated Decision: This will not be changed for consistency with List.

[adrianacastaneda]

Also, noticed an "Edit" button on the featured item field that has a weird experience. It leads to editing the fields of the actual page. This is a different user experience than we usually support for card components so I don't think we should move forward it. Having the "remove" button should be enough!

[bryanpizzillo]

Also, noticed an "Edit" button on the featured item field that has a weird experience. It leads to editing the fields of the actual page. This is a different user experience than we usually support for card components so I don't think we should move forward it. Having the "remove" button should be enough!

That is the paragraphs setting. I will just add it to my ever growing list. 😃

[andyvanavery31]

@dlescarbeau can you please fix:

Front-end:

• The spacing above the optional group heading is wrong and got missed on the storybook testing and that messes up our section spacing rules. It currently has the -16px in the padding of the section, but the additional 19.920px that got brought over from storybook to make the stories work on one page is adding additional whitespace. The total space between the component above it and the top of the group heading should be 32px.

Drupal:

• One imageless card does not automatically get added to the paragraph when the group gets added to the page
• For the cards themselves, the Override Title, Override Description (Internal & Multimedia), Card Title, and Card Description (External) fields do not have the tooltip text from the ACs
• You should not be able to edit the contents of the feature item on internal cards. You should only be able to select and replace the item.
• Change the field name to field_imgless_crd_grp_display
• The heading looks to be Open Sans, not Poppins like the other MLP card elements.
• In the Drupal form, when there is more than one card, they should collapse. See 1st screenshot below where I go back to edit a page and the Imageless Cards are not collapsed but do have the ability to collapse if the user selects it. The 2nd screenshot demonstrates how the feature cards are automatically collapsed. The imageless cards should act the same way.
• See Kate's 2 unit tests comments

[lburack]

• The heading looks to be Open Sans, not Poppins like the other MLP card elements.
• In the Drupal form, when there is more than one card, they should collapse. See 1st screenshot below where I go back to edit a page and the Imageless Cards are not collapsed but do have the ability to collapse if the user selects it. The 2nd screenshot demonstrates how the feature cards are automatically collapsed. The imageless cards should act the same way.
  

[KateMashkinaNIH]

external card URL field should be a simple input - it should not allow an internal link search

[bryanpizzillo]

@andyvanavery31 and @lburack -

In the Drupal form, when there is more than one card, they should collapse. See 1st screenshot below where I go back to edit a page and the Imageless Cards are not collapsed but do have the ability to collapse if the user selects it. The 2nd screenshot demonstrates how the feature cards are automatically collapsed. The imageless cards should act the same way.

I am going to make this be the same configuration as Feature Cards as you "ask". However, The Feature Card Row does not change its behavior on the number -- field_row_cards is always collapsed once it is saved. So remove "when there is more than one card, they should collapse." from the ask.

Also it should be noted that the flag card group does not follow this behavior.

[bennettcc]

This PR has been approved by the Federal team as of 10/29 - Alex and Anna have reviewed

[andyvanavery31]

Passes Product Review.