(#4471) Remove MLP Title Paragraph and add it to MLP Template #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ODE DeploymentCode has been deployed to ODE 857. |
dev-rana-publicis
force-pushed
the
ticket/4471-title
branch
from
ec5e840 to
5657291
Compare
docroot/profiles/custom/cgov_site/modules/custom/cgov_home_landing/cgov_home_landing.install
Show resolved
Hide resolved
dev-rana-publicis
force-pushed
the
ticket/4471-title
branch
2 times, most recently
from
4a9b54e to
2834e9a
Compare
| @@ -1,4 +1,7 @@ | |||
| <!-- Begin MAIN CONTENT AREA --> | |||
| <main class="main-content type {{ page_type }}" id="main-content"> | |||
| <div class="usa-section usa-section--cgdp-no-bottom" data-eddl-landing-row> | |||
| <h1 class="nci-heading-h1">{{ drupal_token('current-page:title')}}</h1> | |||
There was a problem hiding this comment.
You should be able to just reference the node's title here, <h1>{{ node.label }}</h1>, and skip drupal_token. drupal_token should only be used when you can't get the data through a more direct (and more performant) way.
dev-rana-publicis
force-pushed
the
ticket/4471-title
branch
2 times, most recently
from
731c351 to
807ea33
Compare
|
Discussed on 11/12: Needs to be tested on ACSF - will coordinate with O&M team for testing availability |
- Adds update hook to remove paragraph from the database and delete paragraph from any active pages on prod Closes #4471
dev-rana-publicis
force-pushed
the
ticket/4471-title
branch
from
807ea33 to
d89f08e
Compare
|
I looked on www-dev-acsf and there are no errors in the error log, and the paragraph does not exist in structure > Paragraphs. |
bryanpizzillo
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4471