Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#4435, #4520) Stop favicons reverting on code update. #4527

Merged
merged 2 commits into from
Dec 19, 2024
Merged

(#4435, #4520) Stop favicons reverting on code update. #4527

merged 2 commits into from
Dec 19, 2024

Conversation

blairlearn
Copy link
Contributor

Fixes #4435

  • Move favicon settings to install profile.
  • Remove responsive_favicons from cgov_core.features.yml

Fixes #4520

  • Add php zip module to Dockerfile.

@blairlearn blairlearn marked this pull request as ready for review December 12, 2024 23:02
@blairlearn blairlearn requested a review from a team as a code owner December 12, 2024 23:02
@cgdp-management-server
Copy link

ODE Deployment

Code has been deployed to ODE 886.

bryanpizzillo
bryanpizzillo approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@bryanpizzillo bryanpizzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of those looks good to me if testing passes.

@blairlearn blairlearn added the Needs QA review Requires QA regression testing. label Dec 18, 2024
@KateMashkinaNIH KateMashkinaNIH added Passed QA review Regression testing found no issues. and removed Needs QA review Requires QA regression testing. labels Dec 19, 2024
@blairlearn
(#4520) Add php zip module to Dockerfile.
866da77 
Module is required in order to upload favicon zip files in local build.

Closes #4520
@blairlearn
(#4435) Fix bug with favicons reverting to defaults.
b42fbfb 
- Move favicon settings to install profile.
- Remove responsive_favicons from cgov_core.features.yml

Closes #4435
@blairlearn blairlearn merged commit 3ec3631 into develop Dec 19, 2024
5 checks passed
@blairlearn blairlearn deleted the ticket/4435-favicons branch December 19, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanpizzillo bryanpizzillo bryanpizzillo approved these changes

Assignees

@bryanpizzillo bryanpizzillo

Labels
Passed QA review Regression testing found no issues.
Projects
None yet
Milestone
No milestone
3 participants
@blairlearn @bryanpizzillo @KateMashkinaNIH