Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VsCode and EditorConfig best friends again #154

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

nulltoken
Copy link
Collaborator

@nulltoken nulltoken commented Jan 2, 2025

Pull request description

.editorconfig setting states that it's ok to have trailing whitespaces in markdown files (although I'm not sure to understand the reasoning behind this 😉).

This VsCode setting prevents it from short circuiting the editorconfig extension when it's installed.

Related:

Note:
This doesn't add any kind of value to the lib itself.
But as I use both VStudio and VSCode (depending on the kind of change), I eventually got tired all of the useless diff noise when staging changes.

PR meta checklist

  • Pull request is targeted at main branch for code
  • Pull request is linked to all related issues, if any.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

.editorconfig setting states that it's ok to have trailing whitespaces
in markdown files.

This VsCode setting prevents it from short circuiting the editorconfig
extension when it's installed.

Related:
- editorconfig/editorconfig-vscode#153
- microsoft/vscode#65663
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

@nulltoken nulltoken requested a review from linkdotnet January 2, 2025 11:40
Copy link
Member

@linkdotnet linkdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. The root editorconfig can’t handle that? In the *.md section of the file?

@nulltoken
Copy link
Collaborator Author

Hmmm. The root editorconfig can’t handle that? In the *.md section of the file?

It looks like it doesn't. My understanding is that VSCode triggers its own trimming before the EditorConfig extension can chime in to prevent it. See the related issues in the description.

@linkdotnet
Copy link
Member

Ahh, thanks for clarifying. I just skimmed through the issue - if that is the case: Go, go, go for the merge button and big thanks!

@nulltoken nulltoken merged commit a46fa6e into main Jan 2, 2025
4 checks passed
@nulltoken nulltoken deleted the ntk/vscode branch January 2, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants