Use GetRequiredService instead of GetService to resolve jobs #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkdotnet
reviewed
Apr 19, 2024
There was a problem hiding this comment.
LGTM! Thanks for providing a fix and a test.
Can you add an entry to https://github.com/linkdotnet/NCronJob/blob/main/CHANGELOG.md as I use this file for releases.
Done |
linkdotnet
reviewed
Apr 19, 2024
Co-authored-by: Steven Giesel <stgiesel35@gmail.com>
|
Perfect! Thanks again. I will make a release |
falvarez1
pushed a commit
to falvarez1/NCronJob
that referenced
this pull request
Apr 23, 2024
fix: Update CHANGELOG.md Update Changelog.md for 2.0.5 release feat: Use GetRequiredService instead of GetService to resolve jobs (NCronJob-Dev#24) * Use GetRequiredService instead of GetService and added tests * Removed redundant test * Added entry in changelog * Remove empty line in NCronJobIntegrationTests.cs * Update CHANGELOG.md Co-authored-by: Steven Giesel <stgiesel35@gmail.com> --------- Co-authored-by: Steven Giesel <stgiesel35@gmail.com> feat: Added ISSUE template
falvarez1
pushed a commit
to falvarez1/NCronJob
that referenced
this pull request
Apr 23, 2024
…CronJob-Dev#24) * Use GetRequiredService instead of GetService and added tests * Removed redundant test * Added entry in changelog * Remove empty line in NCronJobIntegrationTests.cs * Update CHANGELOG.md Co-authored-by: Steven Giesel <stgiesel35@gmail.com> --------- Co-authored-by: Steven Giesel <stgiesel35@gmail.com>
falvarez1
pushed a commit
to falvarez1/NCronJob
that referenced
this pull request
Apr 24, 2024
…CronJob-Dev#24) * Use GetRequiredService instead of GetService and added tests * Removed redundant test * Added entry in changelog * Remove empty line in NCronJobIntegrationTests.cs * Update CHANGELOG.md Co-authored-by: Steven Giesel <stgiesel35@gmail.com> --------- Co-authored-by: Steven Giesel <stgiesel35@gmail.com>
falvarez1
pushed a commit
to falvarez1/NCronJob
that referenced
this pull request
Apr 24, 2024
…CronJob-Dev#24) * Use GetRequiredService instead of GetService and added tests * Removed redundant test * Added entry in changelog * Remove empty line in NCronJobIntegrationTests.cs * Update CHANGELOG.md Co-authored-by: Steven Giesel <stgiesel35@gmail.com> --------- Co-authored-by: Steven Giesel <stgiesel35@gmail.com>
linkdotnet
added a commit
that referenced
this pull request
Apr 25, 2024
* Updated job scheduling and handling in NCronJob A new `TestCancellationJob` class has been added to simulate a long-running job and handle job cancellation. Everything was made to support async structures to better support error handling and cancellation support. Added preliminary parallel execution support. * enhanced the concurrency management, cleaned up logs * ensure the Tasks are awaited properly to prevent them from persisting beyond the loop scope * remove commented code * This commit encompasses a broad range of improvements and organizational changes to job execution, retry logic, and concurrency management within the system: - **Job and Retry Logic Refactoring:** - Moved `retryHandler` from `CronScheduler` to `JobExecutor` to centralize execution logic. - Consolidated all retry policy-related code into the new `RetryPolicies` folder. - Added `RetryPolicy` attributes with two strategies: exponential backoff and fixed interval. - **Concurrency Enhancements:** - Introduced `SupportsConcurrency` attribute with a `MaxDegreeOfParallelism` parameter to finely control job execution. - Replaced `ConcurrencyConfig` class with `ConcurrencySettings`, incorporating a `MaxDegreeOfParallelism` property. - Updated `CronScheduler` and `NCronJobOptionBuilder` to utilize `ConcurrencySettings`. - Added preliminary support for priority-based queuing of jobs to improve execution efficiency. - **Testing and Samples:** - Added new jobs in `NCronJobSample` project to showcase concurrency capabilities. - Updated sample project configuration, including removal of machine-specific settings and adding `ConcurrencySettings` to `.editorconfig`. - Enhanced `TestCancellationJob` to support a `MaxDegreeOfParallelism` of 10 and added multiple job instances for testing. - **Project Structure and Cleanup:** - Moved job definition files into a dedicated `Jobs` folder. - Removed obsolete pragma directives and updated project settings to reflect new structure and focus. - **Additional Features and Fixes:** - Added auto-detection of precision in `WithCronExpression` when the second parameter is omitted. - Added default values to `SupportsConcurrencyAttribute` to simplify job configuration. - Implemented thread safety in `CronScheduler.cs` to ensure reliable operation under concurrent access. - CronRegistry.RunInstantJob now has a void return type, aligning with expected behavior. * This commit includes multiple refinements and fixes to the retry functionalities and associated tests. Key changes include: - **Retry Attributes**: Minor updates to retry attributes to improve reliability. - **Retry Logic Cleanup**: Cleaned up the retry code and added two new tests to ensure functionality. - **Time Provider Fix**: Resolved issues in TimeProvider that affected tests, ensuring accurate time simulation. - **Retry Issue Resolution**: Addressed specific bugs in the retry mechanisms that affected process stability. - **Job Execution Context**: Changed JobExecutionContext to be an instance of Job Run rather than the Job itself, clarifying execution context. - **Thread Safety in JobOptionBuilder**: Enhanced thread safety and added a test to verify concurrency handling in JobOptionBuilder. - **CronExpression Tests**: Fixed previously broken tests related to CronExpressions and added additional tests to cover new cases. - **optimize scheduler: use precomputed values for cron occurrence * feat: Added ISSUE template * feat: Use GetRequiredService instead of GetService to resolve jobs (#24) * Use GetRequiredService instead of GetService and added tests * Removed redundant test * Added entry in changelog * Remove empty line in NCronJobIntegrationTests.cs * Update CHANGELOG.md Co-authored-by: Steven Giesel <stgiesel35@gmail.com> --------- Co-authored-by: Steven Giesel <stgiesel35@gmail.com> * Update Changelog.md for 2.0.5 release * fix: Update CHANGELOG.md * This commit makes several improvements and bug fixes in the test infrastructure: - **Test Fixes and Enhancements:** - Fixed all existing tests to ensure they are passing and accurately reflecting intended behavior. - Introduced a new version of `WaitForJobsOrTimeout` that allows time advancement for each run, facilitating more precise control over test timing and behavior. * updated info --------- Co-authored-by: Steven Giesel <stgiesel35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #23
Use GetRequiredService to resolve jobs.
Added tests + modified test that broke due to this change.