Add properties for AWS S3 regions, rather than auto-detecting #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a environment variable for the s3 buckets region. Instead of attempting to find the region with ec2 metadata by default, we simply default to `eu-west-1`. This makes more sense as there is really no technical reason why the s3 bucket has to exist in the same region as the application. The old behavior is still available by specifying `auto` as the environment variable, but i believe the default region with no environment variable specified will be sufficient.
gunnarvelle
approved these changes
Sep 7, 2023
|
Har du forresten lagt inn miljøvariabler der det trengs? |
Trenger vi noen ny miljøvariabler da? s3-bøttene kjører vel alle i eu-west-1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fjerner auto-oppdagelse av aws region by default og introduserer miljøvariabler for å spesifisere.
Egentlig mest for å fjerne støyete logging dersom auto-oppdagelsen feiler (lokalt og på CI), men gir også mer mening sånn her, siden det ikke er noen automatikk i at applikasjonene må kjøre i samme region som s3-bøttene.
Så tenkte det var ryddig uansett.
Ny oppførsel:
eu-west-1autogir gammel oppførselIkke så mye å teste egentlig.
Kan se at man ikke får den støyete ec2 metadata fetching failed (e.l) feilmeldingen lokalt.