Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

learningpath-api: Allow feide authentication #536

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

jnatten
Copy link
Contributor

@jnatten jnatten commented Oct 28, 2024

Legger til støtte for å autentisere seg i learningpath-api med FeideAuthorization headeren.
Flytter litt logikk ut av myndla-api for å generalisere det.

Moving `MyNDLAApiClient` to a shared place to maybe allow for sharing
code that fetches users when authenticating feide tokens.
@jnatten jnatten requested a review from a team October 28, 2024 11:13
This patch introduces feide authentication to the learningpath-api
wherever authentication is required.
@gunnarvelle
Copy link
Member

Funker i det minste med å redigere læringsstier med auth0 token fremdeles. Har du god måte å teste med feide?

@jnatten
Copy link
Contributor Author

jnatten commented Oct 28, 2024

Funker i det minste med å redigere læringsstier med auth0 token fremdeles. Har du god måte å teste med feide?

Jeg vet ikke om den er god, men jeg har testet lokalt med postman med et feidetoken fra test 😄

Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenker vi kan ta det inn slik at vi kan begynne å teste det.

@jnatten jnatten merged commit e92488d into master Oct 29, 2024
37 checks passed
@jnatten jnatten deleted the feide-auth-learningpath-api branch October 29, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants