Endpoint to transcribe videos #554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ekrojo77
commented
Dec 5, 2024
•
ekrojo77
commented
- Testing
- Endepunkt for å polle om filen er opprettet
- Bedre return fra GET
ekrojo77
commented
Dec 12, 2024
| case Success(_) => Right(()) | ||
| case Failure(ex) => returnLeftError(ex) | ||
| } | ||
| } |
There was a problem hiding this comment.
Beholder disse i første omgang før vi vet hva som trengs av endepunkt. Men tror det rene transcribe-endepunktet er det som vil bli mest brukt
ekrojo77
changed the title
gunnarvelle
reviewed
Dec 18, 2024
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/model/api/TranscriptionResultDTO.scala
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/service/TranscriptionService.scala
Show resolved
Hide resolved
audio-api/src/test/scala/no/ndla/audioapi/service/TranscriptionServiceTest.scala
Show resolved
Hide resolved
common/src/main/scala/no/ndla/common/brightcove/NdlaBrightcoveClient.scala
Show resolved
Hide resolved
gunnarvelle
reviewed
Dec 20, 2024
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
| val brightcoveClient: NdlaBrightcoveClient | ||
|
|
||
| class NdlaBrightcoveClient { | ||
| private val authUrl = "https://oauth.brightcove.com/v4/access_token" |
There was a problem hiding this comment.
Denne og videoSourceUrl endres nok ikkje, men kunne vore i AudioApiProperties.
There was a problem hiding this comment.
La den i BaseProps i stedet, føltes litt stygt å trekke inn props fra audioApi til en common client
gunnarvelle
reviewed
Jan 3, 2025
| @@ -36,6 +37,13 @@ class AudioApiProperties extends BaseProps with DatabaseProps with StrictLogging | |||
| val StorageName: String = propOrElse("AUDIO_FILE_S3_BUCKET", s"$Environment.audio.ndla") | |||
| val StorageRegion: Option[String] = propOrNone("AUDIO_FILE_S3_BUCKET_REGION") | |||
|
|
|||
| val TranscribeStorageName: String = propOrElse("TRANSCRIBE_FILE_S3_BUCKET_NAME", s"$Environment.transcribe.ndla") | |||
There was a problem hiding this comment.
Kanskje bruke samme format som for filer.
Suggested change
| val TranscribeStorageName: String = propOrElse("TRANSCRIBE_FILE_S3_BUCKET_NAME", s"$Environment.transcribe.ndla") | |
| val TranscribeStorageName: String = propOrElse("TRANSCRIBE_FILE_S3_BUCKET", s"$Environment.transcribe.ndla") |
|
|
||
| val BrightcoveClientId: String = prop("BRIGHTCOVE_API_CLIENT_ID") | ||
| val BrightcoveClientSecret: String = prop("BRIGHTCOVE_API_CLIENT_SECRET") | ||
| val BrightcoveAccountId: String = prop("NDLA_BRIGHTCOVE_ACCOUNT_ID") |
There was a problem hiding this comment.
Denne finnes allerede med dette navnet i secrets
Suggested change
| val BrightcoveAccountId: String = prop("NDLA_BRIGHTCOVE_ACCOUNT_ID") | |
| val BrightcoveAccountId: String = prop("BRIGHTCOVE_ACCOUNT_ID") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.