Add DTO suffix to api types
#559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnatten
force-pushed
the
api-type-naming
branch
from
3c80200 to
10e1d2e
Compare
gunnarvelle
reviewed
Dec 10, 2024
article-api/src/main/scala/no/ndla/articleapi/model/api/ArticleSummaryV2.scala
Outdated
Show resolved
Hide resolved
|
Ganske så breaking, så blir i tilfelle v2 på backend-types |
jnatten
force-pushed
the
api-type-naming
branch
2 times, most recently
from
5b15973 to
508982c
Compare
Tja, vi er under v1 da https://semver.org/#spec-item-4 |
jnatten
force-pushed
the
api-type-naming
branch
2 times, most recently
from
dde75eb to
a25b03e
Compare
jnatten
force-pushed
the
api-type-naming
branch
from
eb1bb76 to
63c4e9c
Compare
gunnarvelle
approved these changes
Dec 10, 2024
Det er de og jeg starter å fikse nu 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jeg syns det har blitt vanskeligere å ha kontroll på importene våre etter vi begynte å bruke
commonog tilsvarende pakker siden vi ikke bare kan importereapiog brukeapi.Articlefeks.Derfor foreslår jeg at api-typene våre kan ha et
DTOsuffix for å slippe å ha samme navn på typer så mange steder.