Only set hideByline if not already set #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnatten
reviewed
Jan 8, 2025
| val image = images.find(i => i.id == imageId) | ||
| embed | ||
| .attr("data-hide-byline", s"${image.exists(i => !i.copyright.license.license.equals("COPYRIGHTED"))}"): Unit | ||
| val noHideByline = !embed.hasAttr("data-hide-byline") |
There was a problem hiding this comment.
Det ble aldri satt data-hide-byline=false?
There was a problem hiding this comment.
Mulig, men tanken min var å droppe å sette dersom verdien allerede er satt.
There was a problem hiding this comment.
Ble disse aldri kjørt siden vi oppdaterer migreringer fremfor å lage nye?
There was a problem hiding this comment.
Den er ikkje kjørt i prod endå. Skal kopiere data fra prod til staging for å verifisere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dette fikser en logisk feil i forrige versjon av migreringa. Det som skjedde då var at om hidebyline var satt så blei ikkje bildeid sendt til imageid, noko som førte til at hidebyline blei satt til false for bilder som var satt inn med hidebyline=true fordi images.find ikkje har bildet som sjekkes.
Dette henter litt fleire bilder fra image-api, men oppdaterer kun dei som ikkje har verdien satt allerede.