search-api: Index grep with dump rather than calling endpoints #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This downloads and extracts a zip of the grep dump to build the `GrepBundle`. This allows us to extract more information about each kode, doesn't really seem that much slower either.
This is replaced by the grep search in search-api. The endpoint will still work for now, but the data will no longer be updated when saving a draft.
To allow us to completely skip calling the udir grep api from the frontend/graphql we need more data! This patch includes everything(?) we need to stop calling the grep api directly from elsewhere.
Since scala-tsi messes up adding the `typename` discriminator we need to hack around it by adding the fields manually to the variants that does not get it 🤷
I broke some tests in the rewrite to fetching grep information via the zipped dump. This patch fixes those.
gunnarvelle
reviewed
Jan 9, 2025
search-api/src/main/scala/no/ndla/searchapi/integration/ZipUtil.scala
Outdated
Show resolved
Hide resolved
search-api/src/main/scala/no/ndla/searchapi/model/api/DescriptionDTO.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dette ble mer greier enn planlagt, men dette funker nå! 😄
tilhoerer-laereplano.l)typenamei graphql.