Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyParagraphButton: Hide on mobile #2513

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katrinewi
Copy link
Contributor

fixes https://github.com/NDLANO/Issues/issues/4158

Det er flere måter dette kan løses på, så bare å komme med eventuelle andre forslag!

@katrinewi katrinewi requested a review from a team September 27, 2024 07:15
@Jonas-C
Copy link
Contributor

Jonas-C commented Sep 27, 2024

Dette funker ikke ordentlig. Prøv f.eks rundt 500px bredde. Ser også ut til å funke dårlig når en heading wrapper.

@katrinewi
Copy link
Contributor Author

Dette funker ikke ordentlig. Prøv f.eks rundt 500px bredde. Ser også ut til å funke dårlig når en heading wrapper.

Haha ånei, jeg som trodde jeg hadde en smart løsning 😅

@katrinewi katrinewi force-pushed the copy-paragraph-button-positioning-mobile branch from e05fc96 to fc1664b Compare September 30, 2024 12:42
@katrinewi katrinewi changed the title CopyParagraphButton: Fix positioning on mobile CopyParagraphButton: Hide on mobile Sep 30, 2024
Copy link
Contributor

@Jonas-C Jonas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM så lenge Hedvig gikk med på det!

@katrinewi
Copy link
Contributor Author

Avventer tilbakemelding på om vi kan legge knappen etter teksten istedet

@katrinewi katrinewi marked this pull request as draft October 17, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants