-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove old icons #2639
Merged
Merged
chore: remove old icons #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c54e5b
to
f514d4b
Compare
This was referenced Dec 2, 2024
4939a8c
to
0d7ecc9
Compare
Kan godt flate ut for min del. |
gunnarvelle
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NDLANO/Issues/issues/4093
Tro det eller ei, denne er breaking! Har korresponderende PR'er i ndla-frontend og ED.
Har gjort to litt crazy ting: Fjernet masse ikoner og renamet mappen fra
ndla-icons
tilicons
.Til den som reviewer: Jeg har delt opp denne i to commits. Den første inneholder nesten alle relevante endringer. Den andre inneholder kun renames. Da kan du med andre ord ignorere alt som ligger i
ndla-icons
ogicons
Når vi er først er i gang: Har vi lyst til å flate ut strukturen her? Sånn at man bare importerer fra
@ndla/icons
?