Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old icons #2639

Merged
merged 9 commits into from
Dec 4, 2024
Merged

chore: remove old icons #2639

merged 9 commits into from
Dec 4, 2024

Conversation

Jonas-C
Copy link
Contributor

@Jonas-C Jonas-C commented Dec 2, 2024

Fixes https://github.com/NDLANO/Issues/issues/4093
Tro det eller ei, denne er breaking! Har korresponderende PR'er i ndla-frontend og ED.

Har gjort to litt crazy ting: Fjernet masse ikoner og renamet mappen fra ndla-icons til icons.

Til den som reviewer: Jeg har delt opp denne i to commits. Den første inneholder nesten alle relevante endringer. Den andre inneholder kun renames. Da kan du med andre ord ignorere alt som ligger i ndla-icons og icons

Når vi er først er i gang: Har vi lyst til å flate ut strukturen her? Sånn at man bare importerer fra @ndla/icons?

@Jonas-C Jonas-C force-pushed the chore/no-old-icons branch from 1c54e5b to f514d4b Compare December 2, 2024 14:59
@Jonas-C Jonas-C marked this pull request as ready for review December 2, 2024 15:04
@Jonas-C Jonas-C requested a review from a team December 2, 2024 15:05
@Jonas-C Jonas-C force-pushed the chore/no-old-icons branch from 4939a8c to 0d7ecc9 Compare December 2, 2024 15:48
@gunnarvelle
Copy link
Member

Kan godt flate ut for min del.

Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jonas-C Jonas-C merged commit 26bf197 into master Dec 4, 2024
4 checks passed
@Jonas-C Jonas-C deleted the chore/no-old-icons branch December 4, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants