Merge pull request #422 from NDLA-H5P/feature/add-link-label

Add label to dialog links
NDLANO · Mar 24, 2022 · 8360056 · 8360056
2 parents 2c852f2 + 5bb613c
commit 8360056
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 6 deletions.
diff --git a/.storybook/helpers/h5p.utils.ts b/.storybook/helpers/h5p.utils.ts
@@ -17,7 +17,10 @@ export const params: Params = {
       topicImage: { path: "", alt: "" },
       dialog: {
         hasNote: true,
-        links: ["https://example.com", "https://example.com/2"],
+        links: [
+          { label: "Example", url: "https://example.com" },
+          { label: "Example 2", url: "https://example.com/2" },
+        ],
       },
       description: "",
     },
@@ -37,7 +40,10 @@ export const params: Params = {
       id: "arrow-1",
       dialog: {
         hasNote: true,
-        links: ["https://example.com", "https://example.com/2"],
+        links: [
+          { label: "Example", url: "https://example.com" },
+          { label: "Example 2", url: "https://example.com/2" },
+        ],
       },
       arrowType: ArrowType.Directional,
       startElementId: "box-1",
@@ -180,7 +186,19 @@ export const semantics: H5PFieldGroup = {
                 field: {
                   label: "Link",
                   name: "link",
-                  type: H5PFieldType.Text,
+                  type: H5PFieldType.Group,
+                  fields: [
+                    {
+                      label: "Label",
+                      name: "label",
+                      type: H5PFieldType.Text,
+                    },
+                    {
+                      label: "Url",
+                      name: "url",
+                      type: H5PFieldType.Text,
+                    },
+                  ],
                 },
               },
             ],
@@ -318,7 +336,19 @@ export const semantics: H5PFieldGroup = {
                 field: {
                   label: "Link",
                   name: "link",
-                  type: H5PFieldType.Text,
+                  type: H5PFieldType.Group,
+                  fields: [
+                    {
+                      label: "Label",
+                      name: "label",
+                      type: H5PFieldType.Text,
+                    },
+                    {
+                      label: "Url",
+                      name: "url",
+                      type: H5PFieldType.Text,
+                    },
+                  ],
                 },
               },
             ],

diff --git a/library.json b/library.json
@@ -3,7 +3,7 @@
   "machineName": "H5PEditor.TopicMap",
   "majorVersion": 0,
   "minorVersion": 1,
-  "patchVersion": 47,
+  "patchVersion": 48,
   "runnable": 0,
   "preloadedJs": [
     {

diff --git a/src/types/DialogContent.ts b/src/types/DialogContent.ts
@@ -1,9 +1,10 @@
 import { Audio } from "./H5P/Audio";
 import { Video } from "./H5P/Video";
+import { Link } from "./Link";
 
 export type DialogContent = {
   hasNote: boolean;
-  links?: Array<string>;
+  links?: Array<Link>;
   text?: string;
   video?: Video;
   audio?: {

diff --git a/src/types/Link.ts b/src/types/Link.ts
@@ -0,0 +1,4 @@
+export type Link = {
+  label: string;
+  url: string;
+};