-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded url #242
Merged
Merged
Expanded url #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnatten
reviewed
Apr 16, 2024
gunnarvelle
force-pushed
the
expanded-url
branch
from
April 17, 2024 13:49
bf5844e
to
be3fb76
Compare
gunnarvelle
force-pushed
the
expanded-url
branch
2 times, most recently
from
April 22, 2024 10:06
b54b745
to
90eee97
Compare
gunnarvelle
force-pushed
the
expanded-url
branch
from
April 22, 2024 10:09
90eee97
to
f10b0d6
Compare
jnatten
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utvider generert url med rot-navn, samt flytter generering til context service. Bruker nb som standard språk i url-generering.
Har også lagt inn et flagg som bestemmer om urler skal genereres med
__
som separator eller med/f/
for fag osv.NDLANO/ndla-frontend#1837 er tenkt å støtte begge formatene på urlene enn så lenge.