Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded url #242

Merged
merged 15 commits into from
May 21, 2024
Merged

Expanded url #242

merged 15 commits into from
May 21, 2024

Conversation

gunnarvelle
Copy link
Member

@gunnarvelle gunnarvelle commented Mar 18, 2024

Utvider generert url med rot-navn, samt flytter generering til context service. Bruker nb som standard språk i url-generering.

Har også lagt inn et flagg som bestemmer om urler skal genereres med __ som separator eller med /f/ for fag osv.
NDLANO/ndla-frontend#1837 er tenkt å støtte begge formatene på urlene enn så lenge.

@gunnarvelle gunnarvelle marked this pull request as ready for review April 16, 2024 08:09
@gunnarvelle gunnarvelle requested a review from a team April 16, 2024 08:09
@gunnarvelle gunnarvelle force-pushed the expanded-url branch 2 times, most recently from b54b745 to 90eee97 Compare April 22, 2024 10:06
Copy link
Contributor

@jnatten jnatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnarvelle gunnarvelle merged commit 4a8644a into master May 21, 2024
3 checks passed
@gunnarvelle gunnarvelle deleted the expanded-url branch May 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants