Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose storagebalanceof as public #26

Open
wants to merge 6 commits into
base: beta
Choose a base branch
from
Open

feat: expose storagebalanceof as public #26

wants to merge 6 commits into from

Conversation

kieranroneill
Copy link
Collaborator

@kieranroneill kieranroneill commented Jun 24, 2024 •
edited
Loading

Description

  • Expose storageBalanceOf as a public function
  • Add storageBalanceOf to the stordageDeposit and storageWithdraw tests
  • Add documentation for the new storageBalanceOf function

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

@kieranroneill kieranroneill added ✨ feature New feature or request ♻️ refactor The refactoring fairy has waved their magic wand labels Jun 24, 2024
@kieranroneill kieranroneill self-assigned this Jun 24, 2024
@kieranroneill kieranroneill linked an issue Jun 24, 2024 that may be closed by this pull request
Expose storageBalanceOf as public #25
Open
jaswinder6991
jaswinder6991 requested changes Aug 14, 2024
View reviewed changes
src/controllers/Social.ts
signer,
}: IStorageBalanceOfOptions): Promise<IStorageBalanceOfResult | null> {
const result: ISocialDBContractStorageBalance | null =
await signer.viewFunction({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the new rpcQueries utility here for view function and eliminate the need of a signer for storageBalanceOf()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaswinder6991 jaswinder6991 jaswinder6991 requested changes

Assignees

@kieranroneill kieranroneill

Labels
✨ feature New feature or request ♻️ refactor The refactoring fairy has waved their magic wand
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose storageBalanceOf as public
2 participants
@kieranroneill @jaswinder6991